intel
[SYCL][Bindless][ABI-Break] adapt the code to the new design of urBindlessImagesImageCopyExp
- updated CGImageCopy to have source and destination image descriptor/formats and remove unneeded MSrcExtent.
- updated handle_impl have source and destination image descriptor/formats and remove unneeded MSrcExtent.
- updated parameter representing source extent from functions piextMemImageCopy and member function MemoryManager::copy_image_bindless.
some of the jobs aren't running properly - here for example
# TODO consider moving this to Dockerfile.
export LD_LIBRARY_PATH=/usr/local/cuda/compat/:/usr/local/cuda/lib64:$LD_LIBRARY_PATH
cmake --build $GITHUB_WORKSPACE/build --target check-sycl
shell: sh -e {0}
env:
CCACHE_DIR: /__w//build_cache_default
CCACHE_MAXSIZE: 8G
Error: /__w/llvm/llvm/build is not a directory
Error: Process completed with exit code 1.
CI is green now.
friendly ping @intel/llvm-reviewers-cuda, @intel/dpcpp-nativecpu-pi-reviewers, @intel/unified-runtime-reviewers and @intel/llvm-reviewers-runtime.
Are there any tests for this change?
yes, almost all bindless images E2E tests uses the copying APIs ext_oneapi_copy. There was no change in the signature of these member functions but their implementation changed. all the tests are passing so there is no regression with this PR.
the list of tests using queue::ext_oneapi_copy overloads:
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_2D.cpp#L52
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_1D.cpp#L85
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_2D_dynamic.cpp#L56
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_3D.cpp#L53
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_sampled.cpp#L170
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_1D.cpp#L49
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_1D_subregion.cpp#L60
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_2D_subregion.cpp#L60
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_3D.cpp#L55
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_3D_subregion.cpp#L61
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/read_write_unsampled.cpp#L226
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/sampling_1D.cpp#L57
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/sampling_2D.cpp#L75
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/sampling_2D_half.cpp#L62
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/sampling_3D.cpp#L54
- https://github.com/codeplaysoftware/intel-llvm-mirror/blob/chedy/new-ur-copy-api/sycl/test-e2e/bindless_images/sampling_unique_addr_modes.cpp#L66
friendly ping @intel/llvm-reviewers-cuda and @intel/unified-runtime-reviewers .
friendly ping @intel/llvm-reviewers-cuda, @intel/unified-runtime-reviewers and @ldrumm.
friendly ping @intel/llvm-reviewers-cuda, @intel/unified-runtime-reviewers and @ldrumm.
The UR PR needs to be approved and merged, the UR tag update, before we'll approve this PR.
