llvm icon indicating copy to clipboard operation
llvm copied to clipboard
verified publisher icon intel

[SYCL] Fix spriv-to-ir-wrapper invocation in clang-linker-wrapper

Open maksimsab opened this issue 1 year ago • 2 comments

Fix command line argument passed to "spirv-to-ir-wrapper" invocation in clang-linker-wrapper. Also make clang-linker-wrapper print arguments quoted if needed.

maksimsab avatar Jun 20 '24 16:06 maksimsab

Also this change fixes the following E2E tests in the New Offloading Model.

SYCL :: Basic/multisource_spv_obj.cpp​ SYCL :: Basic/spirv_device_obj_smoke.cpp​

maksimsab avatar Jun 21 '24 13:06 maksimsab

The point of my change is that we pass the string with whitespaces like "--spirv-option1 --spirv-option2" as one command line argument. The issue before my change was that a printed command was unquoted and it differs from the perspective of the shell. More precisely, it starts being interpreted as two command line arguments instead of one. My change adds quotation when it is needed.

maksimsab avatar Jun 21 '24 15:06 maksimsab

Update: Removed printArg usage. I will have to get it back more accurate directly in llvm-project.

maksimsab avatar Jul 01 '24 14:07 maksimsab

@intel/llvm-gatekeepers Can we merge it? Failure in e2e Windows Intel GEN12 is irrelevant.

maksimsab avatar Jul 03 '24 15:07 maksimsab

Usually I would ask we rerun win gen12 testing but since I know the code changed has no e2e test coverage anyway, i'll just merge it now

sarnex avatar Jul 03 '24 15:07 sarnex