llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[draft][UR] Use urEnqueueNativeCommandExp for enqueue_custom_operation

Open hdelan opened this issue 1 year ago • 2 comments

Use the experimental UR entrypoint urEnqueueNativeCommandExp to implement AdaptiveCPP's AdaptiveCpp_enqueue_custom_operation.

https://github.com/AdaptiveCpp/AdaptiveCpp/blob/develop/doc/enqueue-custom-operation.md

hdelan avatar Jun 11 '24 09:06 hdelan

Ping @illuhad . Should this be AdaptiveCpp_enqueue_custom_operation or ACPP_enqueue_custom_operation?

hdelan avatar Jun 12 '24 14:06 hdelan

@hdelan Great to see! We've recently renamed extensions to AdaptiveCpp_*, so it is now AdaptiveCpp_enqueue_custom_operation. https://github.com/AdaptiveCpp/AdaptiveCpp/pull/1477

illuhad avatar Jun 13 '24 12:06 illuhad

Brief perf results on AMD MI210 courtesy of @hjabird :

For GROMACS on MI210:

Version ADH dodec BenchMEM
Control 84% 96%
ACpp host task (this PR) 90% 100%
Original host task ext ({add/get}_native_events 90% 99%

% of reference performance.

hdelan avatar Jul 01 '24 13:07 hdelan

Ping @MartinWehking @aelovikov-intel @intel/llvm-reviewers-runtime @intel/llvm-reviewers-cuda @intel/sycl-graphs-reviewers

I need to get this merged before the end of week as I'll be on holiday next week before the GitHub cutoff.

hdelan avatar Jul 03 '24 14:07 hdelan

Ping @intel/llvm-reviewers-runtime would be great to get a review on this ASAP as we would like to merge today if spec issues all get resolved

hdelan avatar Jul 18 '24 10:07 hdelan

I have been asked to merge this before the PI removal is merged. So I think this is good to go @intel/llvm-gatekeepers

hdelan avatar Jul 22 '24 12:07 hdelan

@hdelan: I think this PR is still missing approval:

Waiting on code owner review from intel/llvm-reviewers-runtime

sommerlukas avatar Jul 22 '24 13:07 sommerlukas

Aha thanks @sommerlukas I missed that. Where does it say that?

hdelan avatar Jul 22 '24 13:07 hdelan

In that case ping @intel/llvm-reviewers-runtime

hdelan avatar Jul 22 '24 13:07 hdelan

Thanks @aelovikov-intel . Ping @intel/llvm-gatekeepers this can be merged

hdelan avatar Jul 22 '24 16:07 hdelan