llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Use std::array as storage for syc::vec on device

Open uditagarwal97 opened this issue 1 year ago • 2 comments

Changing the storage to std::array instead of Clang's extension fixes strict ansi-alising violation and simplifies device code. This PR also cleans up sycl::vec code.

uditagarwal97 avatar Apr 03 '24 15:04 uditagarwal97

LIT tests failures: Failed Tests (2): SYCL :: basic_tests/types.cpp SYCL :: basic_tests/vectors/constexpr-constructor.cpp

uditagarwal97 avatar Apr 03 '24 17:04 uditagarwal97

sycl/vector_preview.hpp:992:60: error: requested alignment is not an integer constant
[2024-05-16T07:17:19.790Z]    alignas(std::min((size_t)64, sizeof(DataType))) DataType m_Data;

uditagarwal97 avatar May 16 '24 07:05 uditagarwal97

~TODO: Add value_type and element_type in sycl::vec https://github.com/intel/llvm/issues/12954~

uditagarwal97 avatar May 22 '24 20:05 uditagarwal97