llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL] Make swizzle mutating operators const friends

Open steffenlarsen opened this issue 11 months ago • 1 comments

In https://github.com/intel/llvm/pull/12682 the mutating operators for swizzles (+=, -=, ..., ++, --) were reverted to be members rather than friends. Since swizzles mutate the underlying vec rather than themselves these operators should take and return constant references instead, which this commit implements.

steffenlarsen avatar Mar 13 '24 15:03 steffenlarsen

https://github.com/KhronosGroup/SYCL-Docs/pull/514 has been merged. This is ready for review!

steffenlarsen avatar Jun 27 '24 16:06 steffenlarsen

Sorry, grabbed the wrong tag.

@intel/llvm-reviewers-runtime - Friendly ping.

steffenlarsen avatar Jul 12 '24 15:07 steffenlarsen

I believe the change is rather isolated and can be merged without re-test.

aelovikov-intel avatar Jul 16 '24 17:07 aelovikov-intel