llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] test update: support single tile PVC

Open cperkinsintel opened this issue 1 year ago • 2 comments

A few of our tests assume that a given PVC installation always has multiple tiles available, which is not true. Putting appropriate guards into those tests.

cperkinsintel avatar Feb 14 '24 19:02 cperkinsintel

I'm wondering if the code-owner for files should be the L0 team? I believe the intent of UR team being made code-owner for this test directory is that it would eventually be superceeded by UR testing but I'm not sure if that makes sense for these tests or not?

kbenzie avatar Feb 15 '24 14:02 kbenzie

I'm wondering if the code-owner for files should be the L0 team? I believe the intent of UR team being made code-owner for this test directory is that it would eventually be superceeded by UR testing but I'm not sure if that makes sense for these tests or not?

When the feature was first implemented, most of the logic was in plugins/level_zero/pi_level_zero.cpp (https://github.com/intel/llvm/pull/7626/files#diff-15dd1eb076d2164bd9e87d9057f05f652a716498e8cdf5975e564c65309a0985). I believe that that code belongs to UR and as such the test should be owned by it.

aelovikov-intel avatar Feb 15 '24 21:02 aelovikov-intel

closing in favor of https://github.com/intel/llvm/pull/13067

cperkinsintel avatar Mar 19 '24 18:03 cperkinsintel