libyami icon indicating copy to clipboard operation
libyami copied to clipboard

Doesn't work VaapiPostProcessScaler

Open AlexanderKomarov opened this issue 7 years ago • 9 comments

VaapiPostProcessScaler doesn't work. It returns SharedPtr < VideoFrame > with zeros in crop.width and crop.height. I tested it on the vpp test and my application. I use DRM as display. But all tests are passed.

I use Ubuntu 16.04. The latest libva, libyami and intel-vaapi-driver.

AlexanderKomarov avatar Dec 08 '17 08:12 AlexanderKomarov

could you share you command line and try our yamivpp application https://github.com/01org/libyami-utils/blob/master/tests/vpp.cpp like "yamivpp

xuguangxin avatar Dec 11 '17 05:12 xuguangxin

I just run vpp/unittest. Also I added this line std::cout << std::to_string(dest->crop.width) << " " << std::to_string(dest->crop.height) << std::endl; to VppDeinterlace function in vaapipostprocess_scaler_unittest.cpp after this line EXPECT_EQ(YAMI_SUCCESS, scaler.process(src, dest)); And I get only zeros. Is it normal?

I ran our yamivpp application. And it works.

AlexanderKomarov avatar Dec 12 '17 08:12 AlexanderKomarov

Yes, it's defined feature. If crop is zero, It will scale to the entire surface. We have src crop and dest crop. src crop means you only need a sub rect on the source, dest crop means you only need scale src to the sub rect of dest.

xuguangxin avatar Dec 13 '17 03:12 xuguangxin

ok, thank you for the answer.

Also quick question I tried to test YAMI_FOURCC_Y800 format for scaling but I get the error: "the requested function is not implemented". Do you plan to support it? And where can I get the list of supported formats for scaling?

AlexanderKomarov avatar Dec 14 '17 06:12 AlexanderKomarov

It's the error returned by libva. we depend on libva to do vpp.

Hi @xhaihao, Can we query csc format in libva?

HI @AlexanderKomarov Could you share us the usecase? Why you need Y800 scaling?

thanks

xuguangxin avatar Dec 14 '17 06:12 xuguangxin

vaQuerySurfaceAttributes can return the supported surface attribute list for a given config, including pixel formats

xhaihao avatar Dec 14 '17 07:12 xhaihao

@xuguangxin @xhaihao thanks for the answers.

We try to use Intel GPU for decoding/encoding JPEG from camera, scaling and transforming images. We use gray image in our system. Our system does face detection and face recognition.

AlexanderKomarov avatar Dec 14 '17 10:12 AlexanderKomarov

@xuguangxin @xhaihao maybe is there some sense to add the issue of adding support Y800 for vpp in libva project?

AlexanderKomarov avatar Dec 15 '17 11:12 AlexanderKomarov

@xhaihao , what's the suggestion?:)

xuguangxin avatar Dec 15 '17 13:12 xuguangxin