libva icon indicating copy to clipboard operation
libva copied to clipboard

Published 20 hours ago • verified publisher icon intel

Missing declarations

Open evelikov opened this issue 2 years ago • 3 comments

This PR fixes the existing Wmissing-declarations and makes it an explicit Werror=missing... so we don't get new instances.

About the changes themselves:

  • some (should be) internal functions are annotated with DLL_HIDDEN - search in Arch and Github shows zero users
  • some declarations were pulled - explicitly or via respective headers
  • some unnessesary code (lacking declarations) was removed - was https://github.com/intel/libva/pull/667

/cc @sivileri for the Windows libva.def changes. If MSVC has equivalent toggle, let's add it to meson.build

evelikov avatar Dec 20 '22 20:12 evelikov

Can you, please, start from submitting an issue? What is actually wrong? You are saying we have some warnings, but we don't have them exposed in the ci:

I'm a little confused: -Wmissing-declarations is something that is covered in the first semester at university with programming 101, so explicitly opening an issue is very (and I do mean very) patronising IMHO. *Then again, since you see such great value in it I'll open one.

Speaking of issues - we have 96 of them and they are severely neglected. Adding more in there *is a little worrysome.

evelikov avatar Dec 23 '22 09:12 evelikov

Latest ci don't show any warnings for gcc or clang on ubuntu (see https://github.com/intel/libva/actions/runs/3759541222/jobs/6389228741). The only thing I ask is to share a log with warnings you observe when you added additional compiler flag(s). This will help to review your PR since it will be possible to correlate your changes with the warnings from the compiler. I really don't understand why this ask has caused such a reaction from your side.

2022-12-22T16:42:36.3792265Z ninja: Entering directory `./builddir'
2022-12-22T16:42:36.4712027Z [1/32] Compiling C object 'va/198dea3@@va@sha/va_compat.c.o'.
2022-12-22T16:42:36.4908264Z [2/32] Compiling C object 'va/198dea3@@va@sha/va_str.c.o'.
2022-12-22T16:42:36.6507109Z [3/32] Compiling C object 'va/198dea3@@va-drm@sha/drm_va_drm.c.o'.
2022-12-22T16:42:36.7544495Z [4/32] Compiling C object 'va/198dea3@@va-drm@sha/drm_va_drm_auth.c.o'.
2022-12-22T16:42:36.9223832Z [5/32] Compiling C object 'va/198dea3@@va-drm@sha/drm_va_drm_utils.c.o'.
2022-12-22T16:42:37.0270355Z [6/32] Compiling C object 'va/198dea3@@va@sha/va.c.o'.
2022-12-22T16:42:37.0714054Z [7/32] Compiling C object 'va/198dea3@@va-drm@sha/drm_va_drm_auth_x11.c.o'.
2022-12-22T16:42:37.3944919Z [8/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_dri2_util.c.o'.
2022-12-22T16:42:37.4423112Z [9/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_dri2.c.o'.
2022-12-22T16:42:37.5219228Z [10/32] Compiling C object 'va/198dea3@@va-x11@sha/drm_va_drm_utils.c.o'.
2022-12-22T16:42:37.6140382Z [11/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_dricommon.c.o'.
2022-12-22T16:42:37.6391590Z [12/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_dri3.c.o'.
2022-12-22T16:42:37.6566035Z [13/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_fglrx.c.o'.
2022-12-22T16:42:37.7261569Z [14/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_nvctrl.c.o'.
2022-12-22T16:42:37.8181331Z [15/32] Compiling C object 'va/198dea3@@va-x11@sha/x11_va_x11.c.o'.
2022-12-22T16:42:37.9960932Z [16/32] Compiling C object 'va/198dea3@@va-glx@sha/glx_va_glx.c.o'.
2022-12-22T16:42:38.0321734Z [17/32] Generating wayland-drm-client-protocol.c with a custom command.
2022-12-22T16:42:38.0526510Z [18/32] Generating wayland-drm-client-protocol.h with a custom command.
2022-12-22T16:42:38.1583194Z [19/32] Compiling C object 'va/198dea3@@va-glx@sha/glx_va_glx_impl.c.o'.
2022-12-22T16:42:38.1601615Z [20/32] Compiling C object 'va/198dea3@@va-wayland@sha/meson-generated_.._wayland-drm-client-protocol.c.o'.
2022-12-22T16:42:38.2522281Z [21/32] Compiling C object 'va/198dea3@@va-wayland@sha/wayland_va_wayland.c.o'.
2022-12-22T16:42:38.2900589Z [22/32] Compiling C object 'va/198dea3@@va-wayland@sha/wayland_va_wayland_emgd.c.o'.
2022-12-22T16:42:38.3674205Z [23/32] Compiling C object 'va/198dea3@@va-wayland@sha/drm_va_drm_utils.c.o'.
2022-12-22T16:42:38.3895718Z [24/32] Compiling C object 'va/198dea3@@va-wayland@sha/wayland_va_wayland_drm.c.o'.
2022-12-22T16:42:39.3125681Z [25/32] Compiling C object 'va/198dea3@@va@sha/va_trace.c.o'.
2022-12-22T16:42:39.3568256Z [26/32] Linking target va/libva.so.2.1700.0.
2022-12-22T16:42:39.6950311Z [27/32] Generating symbol file 'va/198dea3@@va@sha/libva.so.2.1700.0.symbols'.
2022-12-22T16:42:39.7493918Z [28/32] Linking target va/libva-x11.so.2.1700.0.
2022-12-22T16:42:39.7522484Z [29/32] Linking target va/libva-wayland.so.2.1700.0.
2022-12-22T16:42:39.7622068Z [30/32] Linking target va/libva-drm.so.2.1700.0.
2022-12-22T16:42:39.9697855Z [31/32] Generating symbol file 'va/198dea3@@va-x11@sha/libva-x11.so.2.1700.0.symbols'.
2022-12-22T16:42:40.0225906Z [32/32] Linking target va/libva-glx.so.2.1700.0.

dvrogozh avatar Dec 23 '22 15:12 dvrogozh