libva icon indicating copy to clipboard operation
libva copied to clipboard

va_trace: annotate internal functions with DLL_HIDDEN

Open evelikov opened this issue 3 years ago • 2 comments

Annotate the following functions with DLL_HIDDEN:

  • va_errorMessage
  • va_infoMessage
  • va_parseConfig
  • va_TraceEvent
  • va_TraceEventBuffers
  • va_TraceStatus

The APIs have been used solely within libva.so ever since they were introduced. As such we can safely hide it was never used externally and it's not part of the public API.

-- Couple of the above (aka va_TraceEvent*) were added recently with https://github.com/intel/libva/pull/552, others like va_TraceStatus have been around since 2019, while the rest have been a thing for even longer.

@lindongw to double-check the va_TraceEvent symbols that you've added are meant to be internal-only, correct?

evelikov avatar Oct 02 '22 11:10 evelikov

@XinfengZhang @dvrogozh these are safe to backport to 2.16

evelikov avatar Oct 02 '22 11:10 evelikov

yes, va_TraceEvent is internal funcation

lindongw avatar Oct 10 '22 00:10 lindongw

@XinfengZhang @dvrogozh ping?

evelikov avatar Oct 21 '22 19:10 evelikov

@XinfengZhang can we merge this?

evelikov avatar Oct 28 '22 11:10 evelikov