libva icon indicating copy to clipboard operation
libva copied to clipboard

meson: set HAVE_VA_X11 when applicable

Open evelikov opened this issue 1 year ago • 5 comments

Without the define, we'll end without the Xorg auth whenever the DRM display is used.


Team please consider porting this for the stable releases. Thanks

evelikov avatar Jul 07 '22 23:07 evelikov

v2: move to va/meson.build, consistently use WITH_X11 (current code uses only x11_dep.found())

evelikov avatar Jul 11 '22 13:07 evelikov

@ceyusa as the original author of the meson build, do you mind having a look?

evelikov avatar Jul 12 '22 16:07 evelikov

@XinfengZhang @uartie humble ping?

evelikov avatar Jul 13 '22 12:07 evelikov

otherwise, it looks good and necessary for completeness. I agree on back porting it to stable release.

ceyusa avatar Jul 15 '22 15:07 ceyusa

It seems there is also another issue related to meson x11 path, here:

https://github.com/intel/libva/blob/0a989c9f0af69dcb15253945228c53780f019b79/meson.build#L91

Isn't that a typo: s/with_glx/with_x11/?

Nope, the check is correct - as the error message just below it says.

evelikov avatar Aug 14 '22 17:08 evelikov

It seems there is also another issue related to meson x11 path, here: https://github.com/intel/libva/blob/0a989c9f0af69dcb15253945228c53780f019b79/meson.build#L91

Isn't that a typo: s/with_glx/with_x11/?

Nope, the check is correct - as the error message just below it says.

Yep. You are right.

dvrogozh avatar Aug 15 '22 02:08 dvrogozh