libva icon indicating copy to clipboard operation
libva copied to clipboard

Added VAConfigAttribType VAConfigAttribMaxInputStreams for video

Open FurongZhang opened this issue 3 years ago • 7 comments

composition in video processing.

This attribute determines the maximum number of input streams which the driver supports for a given configuration.

Signed-off-by: Furong Zhang [email protected]

FurongZhang avatar Feb 22 '22 15:02 FurongZhang

Sample code: VAConfigAttrib attrib; attrib.type = VAConfigAttribMaxInputStreams; va_status = vaGetConfigAttributes(va_dpy, VAProfileNone, VAEntrypointVideoProc, &attrib, 1); CHECK_VASTATUS(va_status, "vaGetConfigAttributes"); uint32_t nMaxInStreams = attrib. value;

if (src_batch.size() <= nMaxInStreams) VA_CALL(vtable.vaRenderPicture(context, _context->Id(), &pipeline_param_buf_ids[0], src_batch.size()));

FurongZhang avatar Feb 23 '22 00:02 FurongZhang

May each pipeline parameter in the array have a difference filter chain ?

xhaihao avatar Feb 23 '22 02:02 xhaihao

May each pipeline parameter in the array have a difference filter chain ?

Yes, @xhaihao .

Filters could be different for every pipeline. This PR is expose the max number of input streams (Pipelines).

Pipeline 0: Input0 -> Filter0 -> Filter1->..->Filter x Pipeline 1: Input1 -> Filter1 -> Filter1->..->Filter x .... Pipeline m: Inputm -> Filter1 -> Filter1->..->Filter x

FurongZhang avatar Feb 23 '22 06:02 FurongZhang

  1. suppose better to rename VAConfigAttribMaxInputStreams to VAConfigAttribVideoProcMaxInputStreams or VAConfigAttribMaxBatchSize
  2. why not add a field into VAProcPipelineCaps? it is a VPP pipeline related parameters, max number of pipelines per submission .

XinfengZhang avatar Mar 01 '22 05:03 XinfengZhang

  1. suppose better to rename VAConfigAttribMaxInputStreams to VAConfigAttribVideoProcMaxInputStreams or VAConfigAttribMaxBatchSize
  2. why not add a field into VAProcPipelineCaps? it is a VPP pipeline related parameters, max number of pipelines per submission .

Filters could be different for every pipeline. This PR is expose the max number of input streams (Pipelines).

Pipeline 0: Input0 -> Filter0 -> Filter1->..->Filter x Pipeline 1: Input1 -> Filter1 -> Filter1->..->Filter x .... Pipeline m: Inputm -> Filter1 -> Filter1->..->Filter x

I understand this possibility, but not reply the question

FurongZhang avatar Apr 29 '22 04:04 FurongZhang

  1. suppose better to rename VAConfigAttribMaxInputStreams to VAConfigAttribVideoProcMaxInputStreams or VAConfigAttribMaxBatchSize
  2. why not add a field into VAProcPipelineCaps? it is a VPP pipeline related parameters, max number of pipelines per submission .

Filters could be different for every pipeline. This PR is expose the max number of input streams (Pipelines).

Pipeline 0: Input0 -> Filter0 -> Filter1->..->Filter x Pipeline 1: Input1 -> Filter1 -> Filter1->..->Filter x .... Pipeline m: Inputm -> Filter1 -> Filter1->..->Filter x

sorry for an meaningless comment, what I want to comment is that it does not answer the 2 question.

XinfengZhang avatar Apr 29 '22 06:04 XinfengZhang

sorry for the incorrect operation, I suppose I clicked incorrect button, I do not want to close the PR.

XinfengZhang avatar May 05 '22 02:05 XinfengZhang