libva icon indicating copy to clipboard operation
libva copied to clipboard

build: Wayland scanner should generate private code.

Open ceyusa opened this issue 2 years ago • 2 comments

wayland-scanner emits a warning:

Using "code" is deprecated - use private-code or public-code. See the help page for details.

This patch updates argument to private-code.

ceyusa avatar Sep 30 '21 14:09 ceyusa

The person who added private-code and public-code to wayland-scanner, here o/

Can we get this PR merged?

evelikov avatar Jul 08 '22 00:07 evelikov

@XinfengZhang @uartie humble ping?

evelikov avatar Jul 13 '22 12:07 evelikov

On second thought I think we need a couple of small tweaks:

  • check for newer versions of wayland-scanner - anything recent/supported will have it installed, but configure/meson should check
  • the export.c file (git grep for all references) with the symbol hack should be nuked

@ceyusa can you sort these out? Perhaps we'll see this merged before it's 1 year anniversary :-P

evelikov avatar Sep 08 '22 13:09 evelikov

On second thought I think we need a couple of small tweaks

@evelikov : do you consider these important to be done within this PR or this can be done in other PR? @ceyusa?

dvrogozh avatar Sep 09 '22 18:09 dvrogozh

Yes, I can do it in a follow up PR.

ceyusa avatar Sep 10 '22 10:09 ceyusa

Upon closer look the meson wayland handling is tad busted on a number of levels. Will open a proper MR in a moment

evelikov avatar Sep 11 '22 11:09 evelikov

Superseded by https://github.com/intel/libva/pull/542

evelikov avatar Sep 11 '22 12:09 evelikov

Superseded by #542

You mean, by #627?

dvrogozh avatar Sep 11 '22 14:09 dvrogozh

Done with #627 (merged).

dvrogozh avatar Sep 15 '22 15:09 dvrogozh