intel-qs icon indicating copy to clipboard operation
intel-qs copied to clipboard

Why is IQS not building after April 2021 release? Add "iqs" namespace.

Open giangiac opened this issue 3 years ago • 3 comments

Hi all, I opened this issue as a way to communicate with all users. In April 2021 we released IQS 2.1.0 This version includes new features and examples (see CHANGELOG for a short list), but also some code cleaning. As part of adopting good coding practices, we collect all IQS class and methods in namespace "iqs". If you have problems re-building previous projects, this may be the reason.

The fix is simple. In C++, when declaring a new QubitRegister object just use: QubitRegister(...) ---> iqs::QubitRegister(...)

giangiac avatar Apr 15 '21 07:04 giangiac

I used the name 'iqs' myself as a sub-namespace in my project's namespace structure. This can be fixed by using the ::iqs::QubitRegister to access the new top-level namespace 'iqs'.

mbuchberger1967 avatar Jul 17 '21 20:07 mbuchberger1967

Is it enough to use ::iqs::QubitRegister in your project's code, or should the leading "::" be used in this repository's (i.e. intel-qs) code too?

giangiac avatar Jul 22 '21 15:07 giangiac

It is enough to use ::iqs::QubitRegister in my code. Just as a hint for others, if they run into a similar problem.

mbuchberger1967 avatar Jul 23 '21 07:07 mbuchberger1967