refactor: drop Python 3.8 related code
fixes https://github.com/intel/cve-bin-tool/issues/4579
tests and SBOM generation were already disabled in https://github.com/intel/cve-bin-tool/pull/4647
python_requires was already bumped in https://github.com/intel/cve-bin-tool/pull/5135
uugh, why is copilot commenting on this?
But thank you for getting this moving! I've approved the tests to run.
uugh, why is copilot commenting on this?
because I have Copilot PR reviews enabled (for all my PRs in all repos). There might be a way to disable it in this repo settings specifically using rulesets but I've never done that.
Other than Tests that may fail due to network or HTML all the failed tests on this PR also fail on the main branch
It's basically just this one test in different flavors: test/test_vex.py::TestVexGeneration::test_output_cyclonedx
Duplicating my question from the issue here TLDR: do we want to remove SBOM files for unsupported Python versions? https://github.com/intel/cve-bin-tool/issues/4579#issuecomment-3368289481
I vote we purge the old SBOM files when we stop support. They're still going to be stored in git history and we include them with release packages, so anyone who really wants them can dig for them but hopefully removing them will avoid confusion about what we support in the present.
@terriko @ffontaine can you take another look, please I'd be willing to work on dropping Python 3.9 after this is merged :D