cve-bin-tool
cve-bin-tool copied to clipboard
feat(checker): add System.net.http checker (#35)
Closes #35.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.32%. Comparing base (
d6cbe40
) to head (1c549d6
). Report is 81 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
+ Coverage 75.41% 81.32% +5.91%
==========================================
Files 808 818 +10
Lines 11983 12268 +285
Branches 1598 1654 +56
==========================================
+ Hits 9037 9977 +940
+ Misses 2593 1874 -719
- Partials 353 417 +64
Flag | Coverage Δ | |
---|---|---|
longtests | 80.64% <100.00%> (+5.22%) |
:arrow_up: |
win-longtests | 79.16% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tests are failing because of keyboard interrupt. I don't think it's related to my code changes.
"keyboard interrupt" in this case means that the test timed out, which occasionally happens due to circumstances outside our control (looks like network congestion issues in Azure cloud if I had to guess) but every once in a while happens because the code slowed everything down so much that we exceeded our timeouts.
Anyhow, I've kicked off the tests to re-run to see if this is a persistent failure or a one-off because the backend was having a bad day.
I have tried re-running the tests multiple times on my fork, nonetheless it fails repetitively.
After trying some possibilities, am not able to resolve this windows tests. Going to need some help @terriko
Tests for pytest -n 12 -v --ignore=test/test_cli.py --ignore=test/test_cvedb.py --ignore=test/test_requirements.py --ignore=test/test_html.py --ignore=test/test_json.py
are running fine locally:
The test running locally are running on linux (if i had to guess) so will pass as they are passing here too interesting would to run those on windows machine looking out for timetaken for test to run. (not sure good way to proceed, on first glance the only thing that pop in my head) : )
I did a quick check and it doesn't look like our windows jobs are running very close to the edge of the timeout zone normally. I'm re-running the windows jobs to see if they continue to fail here. (If they do, it could be a performance issue in your code, if they don't, we chalk it up to the windows jobs being really variable on github actions, which they are)
The test running locally are running on linux (if i had to guess) so will pass as they are passing here too interesting would to run those on windows machine looking out for timetaken for test to run. (not sure good way to proceed, on first glance the only thing that pop in my head) : )
Yes, this was run on linux(they were failing on fork). I'm stuck on testing, don't have access to windows for manual tests. And can't really figure out the root cause.
I did a quick check and it doesn't look like our windows jobs are running very close to the edge of the timeout zone normally. I'm re-running the windows jobs to see if they continue to fail here. (If they do, it could be a performance issue in your code, if they don't, we chalk it up to the windows jobs being really variable on github actions, which they are)
Yeah, windows jobs are running OK. None of the tests are failing, but somehow they get stuck at the end, causing a timeout.
Finally!! all tests are passing
Only review and merging left! @terriko