cve-bin-tool icon indicating copy to clipboard operation
cve-bin-tool copied to clipboard

fix: Fix the broken `test_valid_requirements` test

Open ayushthe1 opened this issue 2 years ago • 1 comments

fixes #3644 . The test "test_valid_requirements" in test/test_package_list_parser.py is broken. This PR attempts to fix it.

For more context on why this test is failing and why I have taken this approach to fix this, please refer to my post here on gitter.

ayushthe1 avatar Dec 28 '23 17:12 ayushthe1

Updating the branch to see where we're at. Sorry this fell off my radar!

terriko avatar Jan 18 '24 20:01 terriko

I'm trying to update the branch to see what's going on with this again, but it looks like it's pulling in a bunch of changes I don't want so it may need bigger fixes that I can do through the web interface.

terriko avatar Mar 12 '24 21:03 terriko

Okay, this is not working (as in, the test is still failing) and it looks like a couple of the generated fuzz files somehow are stuck in this pull request.

I'm going to go ahead and close this, but feel free to make a fresh branch with only your test_valid_requirements changes and open it up again if you can get the test to actually work.

terriko avatar Mar 13 '24 23:03 terriko