cve-bin-tool
cve-bin-tool copied to clipboard
feat(data_source): RedHat Security Database
closes #1948
Looks like you're also hitting the windows issue here. Does temporarily disabling GAD fix it?
Codecov Report
Merging #1949 (67a992e) into main (f85b605) will decrease coverage by
1.08%. The diff coverage is90.44%.
:exclamation: Current head 67a992e differs from pull request most recent head 41a811f. Consider uploading reports for the commit 41a811f to get more accurate results
@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
- Coverage 90.00% 88.91% -1.09%
==========================================
Files 397 399 +2
Lines 7881 8036 +155
Branches 991 1012 +21
==========================================
+ Hits 7093 7145 +52
- Misses 517 623 +106
+ Partials 271 268 -3
| Flag | Coverage Δ | |
|---|---|---|
| longtests | 87.35% <90.44%> (-1.06%) |
:arrow_down: |
| win-longtests | 79.81% <57.96%> (-2.39%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| cve_bin_tool/cli.py | 73.86% <75.00%> (+0.27%) |
:arrow_up: |
| cve_bin_tool/data_sources/rsd_source.py | 88.97% <88.97%> (ø) |
|
| cve_bin_tool/cvedb.py | 87.00% <100.00%> (+0.04%) |
:arrow_up: |
| test/test_source_rsd.py | 100.00% <100.00%> (ø) |
|
| cve_bin_tool/nvd_api.py | 24.00% <0.00%> (-52.80%) |
:arrow_down: |
| test/test_nvd_api.py | 50.87% <0.00%> (-40.36%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks like you're also hitting the windows issue here. Does temporarily disabling GAD fix it?
Disabling GAD does seem to fix the errors but the fix #1951 was not related to GAD, which is interesting.
i am not how GAD is related to this yet but the errors were from a setup function in test_cvedb.py which were causing other tests to fail as well.
Hey, how's this one going? It looks like you're just missing some tests.
@terriko Sorry for the late response, was dealing with some health issues. Added tests and documentation, some tests are failing, but they don't seem related.