cve-bin-tool icon indicating copy to clipboard operation
cve-bin-tool copied to clipboard

feat: add ruby language parser (#1939)

Open XDRAGON2002 opened this issue 1 year ago • 2 comments

Closes #1939

XDRAGON2002 avatar Sep 07 '22 15:09 XDRAGON2002

Codecov Report

Merging #1940 (35875f3) into main (2402d71) will decrease coverage by 10.03%. The diff coverage is 97.36%.

@@             Coverage Diff             @@
##             main    #1940       +/-   ##
===========================================
- Coverage   88.38%   78.34%   -10.04%     
===========================================
  Files         318      319        +1     
  Lines        7301     7339       +38     
  Branches     1195     1204        +9     
===========================================
- Hits         6453     5750      -703     
- Misses        573     1333      +760     
+ Partials      275      256       -19     
Flag Coverage Δ
longtests 78.34% <97.36%> (+0.11%) :arrow_up:
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/parsers/__init__.py 95.00% <ø> (ø)
test/test_language_scanner.py 90.00% <92.30%> (+0.34%) :arrow_up:
cve_bin_tool/parsers/parse.py 100.00% <100.00%> (ø)
cve_bin_tool/parsers/ruby.py 100.00% <100.00%> (ø)
test/test_requirements.py 0.00% <0.00%> (-89.88%) :arrow_down:
cve_bin_tool/data_sources/curl_source.py 39.56% <0.00%> (-56.05%) :arrow_down:
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) :arrow_down:
cve_bin_tool/data_sources/nvd_source.py 29.18% <0.00%> (-50.82%) :arrow_down:
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) :arrow_down:
test/test_source_nvd.py 60.71% <0.00%> (-39.29%) :arrow_down:
... and 25 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 07 '22 15:09 codecov-commenter

Resolved the conflicts. Yes, I believe almost all the tests in the file can be unified and easily dealt with by using parameterization. I'll look into it and open an issue for it appropriately.

XDRAGON2002 avatar Sep 17 '22 11:09 XDRAGON2002

Resolved the new merge conflict, running tests.

terriko avatar Sep 26 '22 17:09 terriko