cve-bin-tool
cve-bin-tool copied to clipboard
intel
ci: add pyright (#1584)
Codecov Report
Merging #1598 (7e4f04b) into main (84715ba) will decrease coverage by
0.17%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
- Coverage 81.44% 81.27% -0.18%
==========================================
Files 290 290
Lines 5811 5811
Branches 957 957
==========================================
- Hits 4733 4723 -10
- Misses 856 865 +9
- Partials 222 223 +1
| Flag | Coverage Δ | |
|---|---|---|
| longtests | 81.27% <ø> (-0.18%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| cve_bin_tool/nvd_api.py | 75.00% <0.00%> (-9.49%) |
:arrow_down: |
| cve_bin_tool/cli.py | 70.17% <0.00%> (+0.43%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Updating branch. This looks promising but generates a lot of errors, so we'll have to do some adjustment so that it doesn't make CI look broken all the time.
Updating branch. This looks promising but generates a lot of errors, so we'll have to do some adjustment so that it doesn't make CI look broken all the time.
Agreed, I had also stated the same in #1584.
Note that allowed-to-fail will always show a green check mark (and github seems a bit disinclined to fix that) so don't be surprised by that when you set it up. The logs should show the correct information as needed.
Hey, I'm cleaning up older pull requests before hacktoberfest. What do you want to do with this one? We're still not close to being able to enable type-checking across all files, and the way github handles allowed-to-fail jobs is kind of a mess, so... I'm going to go ahead and close this for now, but feel free to keep it around or re-open a new one to get hacktoberfest credit next month if you feel inspired to sort out how to run it only on the files that pass checks.