cri-resource-manager icon indicating copy to clipboard operation
cri-resource-manager copied to clipboard

e2e: add vm-install-minikube and vm-create-minikube-cluster

Open askervin opened this issue 3 years ago • 4 comments

  • Tested on debian, fedora and ubuntu.
  • Example: distro=fedora on_vm_online=' vm-install-minikube; vm-create-minikube-cluster; vm-command "minikube kubectl -- get pods -A"; exit' test/e2e/run.sh interactive

askervin avatar Sep 29 '22 14:09 askervin

This needs PR #896 if used behind a http_proxy without the default no_proxy including .internal and other no_proxy extensions in the PR.

askervin avatar Sep 29 '22 14:09 askervin

Codecov Report

Merging #897 (b4b8f60) into master (16ab0a5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   34.89%   34.89%           
=======================================
  Files          60       60           
  Lines        8869     8869           
=======================================
  Hits         3095     3095           
  Misses       5472     5472           
  Partials      302      302           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 29 '22 14:09 codecov-commenter

Could some reasoning mentioned in the commit message that why we are adding minikube support?

jukkar avatar Sep 29 '22 14:09 jukkar

Could some reasoning mentioned in the commit message that why we are adding minikube support?

Good point. Reasoning added.

askervin avatar Sep 30 '22 11:09 askervin