--console $(tty) doesn't work — runc dropped the option altogether for --console-socket

[dlespiau]

From Archana in PR https://github.com/01org/cc-oci-runtime/pull/513

In that case, stdio is set up correctly. Do not set the tty as
 * the controlling tty for shim, since this makes the shell run with no
 * controlling tty resulting in the following error:
    	"sudo: no tty present and no askpass program specified"

runc actually removed the --console option in their console rewrite: https://github.com/opencontainers/runc/commit/244c9fc426aeb1993e0ba871b5ee181b190338b6#diff-2d3dd7d378b1b441344cf5027a5e8aa7L33

[dlespiau]

2 little notes:

• We want to keep the --console option as long as docker needs it, of course.
• runc used to have a --console /dev/pts/ptmx in their standalone tests to support what we want, I think: https://github.com/opencontainers/runc/commit/972c176ae45b2451dbd7c81cdbe3a81023c55e1c#diff-ca657af2fedf0135188c8e3924a17c00L15