auto-pts icon indicating copy to clipboard operation
auto-pts copied to clipboard

Support Zephyr BR PTS test cases

Open lylezhu2012 opened this issue 9 months ago • 1 comments

The changes of PR are used to support Zephyr BR PTS test cases.

The changes of Zephyr tester is here

lylezhu2012 avatar Mar 09 '25 13:03 lylezhu2012

Hi @sjanc , Please help review the changes.

lylezhu2012 avatar Mar 10 '25 14:03 lylezhu2012

oh, and for now I think we can live with BR/EDR overlays here, but in long run I think there should be common br_edr config in tester app that is only tuned (if needed) with overlays

sjanc avatar Apr 01 '25 08:04 sjanc

Looks good to me, and thanks for being so persistent on this!

Hi @sjanc , Thanks a lot. Could you help review the changes of zephyr tester here https://github.com/zephyrproject-rtos/zephyr/pull/86822?

And what is the PR workflow of this repo? I mean whether it likes as zephyr, someone will help merge the PR after the PR is ready to be merged. And whether is it required to be approved only when not less than 2 reviewer have approved it?

lylezhu2012 avatar Apr 01 '25 14:04 lylezhu2012

no, merging process is less formal comparing to zephyr's :)

although you need to rebase against master since there are some conflicts preventing me to merge as is

sjanc avatar Apr 01 '25 14:04 sjanc

although you need to rebase against master since there are some conflicts preventing me to merge as is

I have done it.

lylezhu2012 avatar Apr 02 '25 01:04 lylezhu2012

#AutoPTS run zephyr GAP

sjanc avatar Apr 02 '25 09:04 sjanc

Scheduled PR https://github.com/auto-pts/auto-pts/pull/1407#issuecomment-2771958102, board: nrf52, estimated start time: 11:24:22, test case count: 162, estimated duration: 1:13:09

Test cases to be runGAP/BROB/BCST/BV-01-C
GAP/BROB/BCST/BV-02-C
GAP/BROB/BCST/BV-03-C
GAP/BROB/BCST/BV-04-C
GAP/BROB/BCST/BV-05-C
GAP/BROB/OBSV/BV-01-C
GAP/BROB/OBSV/BV-02-C
GAP/BROB/OBSV/BV-05-C
GAP/BROB/OBSV/BV-06-C
GAP/DISC/NONM/BV-01-C
GAP/DISC/NONM/BV-02-C
GAP/DISC/LIMM/BV-03-C
GAP/DISC/LIMM/BV-04-C
GAP/DISC/GENM/BV-03-C
GAP/DISC/GENM/BV-04-C
GAP/DISC/LIMP/BV-01-C
GAP/DISC/LIMP/BV-02-C
GAP/DISC/LIMP/BV-03-C
GAP/DISC/LIMP/BV-04-C
GAP/DISC/LIMP/BV-05-C
GAP/DISC/GENP/BV-01-C
GAP/DISC/GENP/BV-02-C
GAP/DISC/GENP/BV-03-C
GAP/DISC/GENP/BV-04-C
GAP/DISC/GENP/BV-05-C
GAP/DISC/RPA/BV-01-C
GAP/IDLE/NAMP/BV-01-C
GAP/IDLE/NAMP/BV-02-C
GAP/CONN/NCON/BV-01-C
GAP/CONN/NCON/BV-02-C
GAP/CONN/NCON/BV-03-C
GAP/CONN/DCON/BV-01-C
GAP/CONN/DCON/BV-04-C
GAP/CONN/DCON/BV-05-C
GAP/CONN/UCON/BV-01-C
GAP/CONN/UCON/BV-02-C
GAP/CONN/UCON/BV-03-C
GAP/CONN/UCON/BV-06-C
GAP/CONN/ACEP/BV-01-C
GAP/CONN/ACEP/BV-03-C
GAP/CONN/ACEP/BV-04-C
GAP/CONN/GCEP/BV-01-C
GAP/CONN/GCEP/BV-02-C
GAP/CONN/GCEP/BV-05-C
GAP/CONN/GCEP/BV-06-C
GAP/CONN/DCEP/BV-01-C
GAP/CONN/DCEP/BV-03-C
GAP/CONN/DCEP/BV-05-C
GAP/CONN/DCEP/BV-06-C
GAP/CONN/CPUP/BV-01-C
GAP/CONN/CPUP/BV-02-C
GAP/CONN/CPUP/BV-03-C
GAP/CONN/CPUP/BV-04-C
GAP/CONN/CPUP/BV-05-C
GAP/CONN/CPUP/BV-06-C
GAP/CONN/CPUP/BV-08-C
GAP/CONN/CPUP/BV-10-C
GAP/CONN/TERM/BV-01-C
GAP/CONN/PRDA/BV-01-C
GAP/CONN/PRDA/BV-02-C
GAP/BOND/NBON/BV-01-C
GAP/BOND/NBON/BV-02-C
GAP/BOND/NBON/BV-03-C
GAP/BOND/BON/BV-02-C
GAP/BOND/BON/BV-03-C
GAP/BOND/BON/BV-04-C
GAP/SEC/SEM/BV-21-C
GAP/SEC/SEM/BV-37-C
GAP/SEC/SEM/BV-38-C
GAP/SEC/SEM/BV-22-C
GAP/SEC/SEM/BV-39-C
GAP/SEC/SEM/BV-40-C
GAP/SEC/SEM/BV-23-C
GAP/SEC/SEM/BV-24-C
GAP/SEC/SEM/BV-56-C
GAP/SEC/SEM/BV-57-C
GAP/SEC/SEM/BV-58-C
GAP/SEC/SEM/BV-59-C
GAP/SEC/SEM/BV-60-C
GAP/SEC/SEM/BV-61-C
GAP/SEC/SEM/BV-26-C
GAP/SEC/SEM/BV-41-C
GAP/SEC/SEM/BV-42-C
GAP/SEC/SEM/BV-27-C
GAP/SEC/SEM/BV-43-C
GAP/SEC/SEM/BV-44-C
GAP/SEC/SEM/BV-28-C
GAP/SEC/SEM/BV-29-C
GAP/SEC/SEM/BV-62-C
GAP/SEC/SEM/BV-63-C
GAP/SEC/SEM/BV-64-C
GAP/SEC/SEM/BV-65-C
GAP/SEC/SEM/BV-66-C
GAP/SEC/SEM/BV-67-C
GAP/SEC/SEM/BI-09-C
GAP/SEC/SEM/BI-10-C
GAP/SEC/SEM/BI-13-C
GAP/SEC/SEM/BV-45-C
GAP/SEC/SEM/BI-20-C
GAP/SEC/SEM/BI-21-C
GAP/SEC/SEM/BI-22-C
GAP/SEC/SEM/BI-23-C
GAP/SEC/AUT/BV-11-C
GAP/SEC/AUT/BV-12-C
GAP/SEC/AUT/BV-13-C
GAP/SEC/AUT/BV-14-C
GAP/SEC/AUT/BV-17-C
GAP/SEC/AUT/BV-18-C
GAP/SEC/AUT/BV-19-C
GAP/SEC/AUT/BV-20-C
GAP/SEC/AUT/BV-21-C
GAP/SEC/AUT/BV-22-C
GAP/SEC/AUT/BV-23-C
GAP/SEC/AUT/BV-24-C
GAP/SEC/AUT/BV-25-C
GAP/SEC/AUT/BV-26-C
GAP/SEC/AUT/BV-27-C
GAP/SEC/AUT/BV-28-C
GAP/SEC/CSIGN/BV-01-C
GAP/SEC/CSIGN/BV-02-C
GAP/SEC/CSIGN/BI-01-C
GAP/SEC/CSIGN/BI-02-C
GAP/SEC/CSIGN/BI-03-C
GAP/SEC/CSIGN/BI-04-C
GAP/PRIV/CONN/BV-10-C
GAP/PRIV/CONN/BV-11-C
GAP/PRIV/CONN/BV-12-C
GAP/ADV/BV-01-C
GAP/ADV/BV-02-C
GAP/ADV/BV-03-C
GAP/ADV/BV-04-C
GAP/ADV/BV-05-C
GAP/ADV/BV-08-C
GAP/ADV/BV-09-C
GAP/ADV/BV-10-C
GAP/ADV/BV-11-C
GAP/ADV/BV-12-C
GAP/ADV/BV-13-C
GAP/ADV/BV-14-C
GAP/ADV/BV-17-C
GAP/ADV/BV-18-C
GAP/ADV/BV-19-C
GAP/ADV/BV-20-C
GAP/SCN/BV-01-C
GAP/PADV/PASM/BV-01-C
GAP/PADV/PAM/BV-01-C
GAP/PADV/PASE/BV-01-C
GAP/PADV/PASE/BV-02-C
GAP/PADV/PASE/BV-03-C
GAP/PADV/PASE/BV-04-C
GAP/PADV/PASE/BV-05-C
GAP/PADV/PASE/BV-06-C
GAP/PADV/PAST/BV-01-C
GAP/PADV/PAST/BV-02-C
GAP/GAT/BV-04-C
GAP/GAT/BV-05-C
GAP/GAT/BV-06-C
GAP/GAT/BV-16-C
GAP/GAT/BV-17-C
GAP/GAT/BV-18-C
GAP/BIS/BSE/BV-01-C
GAP/BIS/BBM/BV-01-C

codecoup-tester avatar Apr 02 '25 09:04 codecoup-tester

AutoPTS Bot results:

Failed tests (12)GAP GAP/ADV/BV-20-C MISSING WID ERROR
GAP GAP/BIS/BBM/BV-01-C MISSING WID ERROR
GAP GAP/BIS/BSE/BV-01-C INDCSV
GAP GAP/PADV/PASE/BV-02-C INDCSV
GAP GAP/PADV/PASE/BV-03-C BTP ERROR
GAP GAP/PADV/PASE/BV-04-C BTP ERROR
GAP GAP/PADV/PASE/BV-05-C BTP ERROR
GAP GAP/PADV/PASE/BV-06-C BTP ERROR
GAP GAP/PADV/PAST/BV-01-C BTP ERROR
GAP GAP/PADV/PAST/BV-02-C BTP ERROR
GAP GAP/SCN/BV-01-C MISSING WID ERROR
GAP GAP/SEC/SEM/BI-13-C MISSING WID ERROR
Successful tests (150)GAP GAP/ADV/BV-01-C PASS
GAP GAP/ADV/BV-02-C PASS
GAP GAP/ADV/BV-03-C PASS
GAP GAP/ADV/BV-04-C PASS
GAP GAP/ADV/BV-05-C PASS
GAP GAP/ADV/BV-08-C PASS
GAP GAP/ADV/BV-09-C PASS
GAP GAP/ADV/BV-10-C PASS
GAP GAP/ADV/BV-11-C PASS
GAP GAP/ADV/BV-12-C PASS
GAP GAP/ADV/BV-13-C PASS
GAP GAP/ADV/BV-14-C PASS
GAP GAP/ADV/BV-17-C PASS
GAP GAP/ADV/BV-18-C PASS
GAP GAP/ADV/BV-19-C PASS
GAP GAP/BOND/BON/BV-02-C PASS
GAP GAP/BOND/BON/BV-03-C PASS
GAP GAP/BOND/BON/BV-04-C PASS
GAP GAP/BOND/NBON/BV-01-C PASS
GAP GAP/BOND/NBON/BV-02-C PASS
GAP GAP/BOND/NBON/BV-03-C PASS
GAP GAP/BROB/BCST/BV-01-C PASS (2)
GAP GAP/BROB/BCST/BV-02-C PASS
GAP GAP/BROB/BCST/BV-03-C PASS
GAP GAP/BROB/BCST/BV-04-C PASS
GAP GAP/BROB/BCST/BV-05-C PASS
GAP GAP/BROB/OBSV/BV-01-C PASS
GAP GAP/BROB/OBSV/BV-02-C PASS
GAP GAP/BROB/OBSV/BV-05-C PASS
GAP GAP/BROB/OBSV/BV-06-C PASS
GAP GAP/CONN/ACEP/BV-01-C PASS
GAP GAP/CONN/ACEP/BV-03-C PASS
GAP GAP/CONN/ACEP/BV-04-C PASS
GAP GAP/CONN/CPUP/BV-01-C PASS
GAP GAP/CONN/CPUP/BV-02-C PASS
GAP GAP/CONN/CPUP/BV-03-C PASS
GAP GAP/CONN/CPUP/BV-04-C PASS
GAP GAP/CONN/CPUP/BV-05-C PASS
GAP GAP/CONN/CPUP/BV-06-C PASS
GAP GAP/CONN/CPUP/BV-08-C PASS
GAP GAP/CONN/CPUP/BV-10-C PASS
GAP GAP/CONN/DCEP/BV-01-C PASS
GAP GAP/CONN/DCEP/BV-03-C PASS
GAP GAP/CONN/DCEP/BV-05-C PASS
GAP GAP/CONN/DCEP/BV-06-C PASS
GAP GAP/CONN/DCON/BV-01-C PASS
GAP GAP/CONN/DCON/BV-04-C PASS
GAP GAP/CONN/DCON/BV-05-C PASS
GAP GAP/CONN/GCEP/BV-01-C PASS
GAP GAP/CONN/GCEP/BV-02-C PASS
GAP GAP/CONN/GCEP/BV-05-C PASS
GAP GAP/CONN/GCEP/BV-06-C PASS
GAP GAP/CONN/NCON/BV-01-C PASS
GAP GAP/CONN/NCON/BV-02-C PASS
GAP GAP/CONN/NCON/BV-03-C PASS
GAP GAP/CONN/PRDA/BV-01-C PASS
GAP GAP/CONN/PRDA/BV-02-C PASS
GAP GAP/CONN/TERM/BV-01-C PASS
GAP GAP/CONN/UCON/BV-01-C PASS
GAP GAP/CONN/UCON/BV-02-C PASS
GAP GAP/CONN/UCON/BV-03-C PASS
GAP GAP/CONN/UCON/BV-06-C PASS
GAP GAP/DISC/GENM/BV-03-C PASS
GAP GAP/DISC/GENM/BV-04-C PASS
GAP GAP/DISC/GENP/BV-01-C PASS
GAP GAP/DISC/GENP/BV-02-C PASS
GAP GAP/DISC/GENP/BV-03-C PASS
GAP GAP/DISC/GENP/BV-04-C PASS
GAP GAP/DISC/GENP/BV-05-C PASS
GAP GAP/DISC/LIMM/BV-03-C PASS
GAP GAP/DISC/LIMM/BV-04-C PASS
GAP GAP/DISC/LIMP/BV-01-C PASS
GAP GAP/DISC/LIMP/BV-02-C PASS
GAP GAP/DISC/LIMP/BV-03-C PASS
GAP GAP/DISC/LIMP/BV-04-C PASS
GAP GAP/DISC/LIMP/BV-05-C PASS
GAP GAP/DISC/NONM/BV-01-C PASS
GAP GAP/DISC/NONM/BV-02-C PASS
GAP GAP/DISC/RPA/BV-01-C PASS
GAP GAP/GAT/BV-04-C PASS
GAP GAP/GAT/BV-05-C PASS
GAP GAP/GAT/BV-06-C PASS
GAP GAP/GAT/BV-16-C PASS - ERRATA ES-26322
GAP GAP/GAT/BV-17-C PASS - ERRATA ES-26322
GAP GAP/GAT/BV-18-C PASS
GAP GAP/IDLE/NAMP/BV-01-C PASS
GAP GAP/IDLE/NAMP/BV-02-C PASS
GAP GAP/PADV/PAM/BV-01-C PASS
GAP GAP/PADV/PASE/BV-01-C PASS
GAP GAP/PADV/PASM/BV-01-C PASS
GAP GAP/PRIV/CONN/BV-10-C PASS
GAP GAP/PRIV/CONN/BV-11-C PASS
GAP GAP/PRIV/CONN/BV-12-C PASS
GAP GAP/SEC/AUT/BV-11-C PASS
GAP GAP/SEC/AUT/BV-12-C PASS
GAP GAP/SEC/AUT/BV-13-C PASS
GAP GAP/SEC/AUT/BV-14-C PASS
GAP GAP/SEC/AUT/BV-17-C PASS
GAP GAP/SEC/AUT/BV-18-C PASS
GAP GAP/SEC/AUT/BV-19-C PASS
GAP GAP/SEC/AUT/BV-20-C PASS
GAP GAP/SEC/AUT/BV-21-C PASS
GAP GAP/SEC/AUT/BV-22-C PASS
GAP GAP/SEC/AUT/BV-23-C PASS
GAP GAP/SEC/AUT/BV-24-C PASS
GAP GAP/SEC/AUT/BV-25-C PASS
GAP GAP/SEC/AUT/BV-26-C PASS
GAP GAP/SEC/AUT/BV-27-C PASS
GAP GAP/SEC/AUT/BV-28-C PASS
GAP GAP/SEC/CSIGN/BI-01-C PASS
GAP GAP/SEC/CSIGN/BI-02-C PASS
GAP GAP/SEC/CSIGN/BI-03-C PASS
GAP GAP/SEC/CSIGN/BI-04-C PASS
GAP GAP/SEC/CSIGN/BV-01-C PASS
GAP GAP/SEC/CSIGN/BV-02-C PASS
GAP GAP/SEC/SEM/BI-09-C PASS
GAP GAP/SEC/SEM/BI-10-C PASS
GAP GAP/SEC/SEM/BI-20-C PASS
GAP GAP/SEC/SEM/BI-21-C PASS
GAP GAP/SEC/SEM/BI-22-C PASS
GAP GAP/SEC/SEM/BI-23-C PASS
GAP GAP/SEC/SEM/BV-21-C PASS
GAP GAP/SEC/SEM/BV-22-C PASS
GAP GAP/SEC/SEM/BV-23-C PASS
GAP GAP/SEC/SEM/BV-24-C PASS
GAP GAP/SEC/SEM/BV-26-C PASS
GAP GAP/SEC/SEM/BV-27-C PASS
GAP GAP/SEC/SEM/BV-28-C PASS
GAP GAP/SEC/SEM/BV-29-C PASS
GAP GAP/SEC/SEM/BV-37-C PASS
GAP GAP/SEC/SEM/BV-38-C PASS
GAP GAP/SEC/SEM/BV-39-C PASS
GAP GAP/SEC/SEM/BV-40-C PASS
GAP GAP/SEC/SEM/BV-41-C PASS
GAP GAP/SEC/SEM/BV-42-C PASS
GAP GAP/SEC/SEM/BV-43-C PASS
GAP GAP/SEC/SEM/BV-44-C PASS
GAP GAP/SEC/SEM/BV-45-C PASS
GAP GAP/SEC/SEM/BV-56-C PASS
GAP GAP/SEC/SEM/BV-57-C PASS
GAP GAP/SEC/SEM/BV-58-C PASS
GAP GAP/SEC/SEM/BV-59-C PASS
GAP GAP/SEC/SEM/BV-60-C PASS
GAP GAP/SEC/SEM/BV-61-C PASS
GAP GAP/SEC/SEM/BV-62-C PASS
GAP GAP/SEC/SEM/BV-63-C PASS
GAP GAP/SEC/SEM/BV-64-C PASS
GAP GAP/SEC/SEM/BV-65-C PASS
GAP GAP/SEC/SEM/BV-66-C PASS
GAP GAP/SEC/SEM/BV-67-C PASS

codecoup-tester avatar Apr 02 '25 11:04 codecoup-tester

AutoPTS Bot results:

Failed tests (12) GAP GAP/ADV/BV-20-C MISSING WID ERROR GAP GAP/BIS/BBM/BV-01-C MISSING WID ERROR GAP GAP/BIS/BSE/BV-01-C INDCSV GAP GAP/PADV/PASE/BV-02-C INDCSV GAP GAP/PADV/PASE/BV-03-C BTP ERROR GAP GAP/PADV/PASE/BV-04-C BTP ERROR GAP GAP/PADV/PASE/BV-05-C BTP ERROR GAP GAP/PADV/PASE/BV-06-C BTP ERROR GAP GAP/PADV/PAST/BV-01-C BTP ERROR GAP GAP/PADV/PAST/BV-02-C BTP ERROR GAP GAP/SCN/BV-01-C MISSING WID ERROR GAP GAP/SEC/SEM/BI-13-C MISSING WID ERROR

Hi @codecoup-tester , thank you for your effort.

How about the result of the failed cases without the changes of this PR? All of the failed cases belong to LE only. So, I do not think the reason of the failed cases are related to my changes.

lylezhu2012 avatar Apr 02 '25 11:04 lylezhu2012

those are failing on master too, this looks good to be merge but github is getting bran-fart claiming that "This branch cannot be rebased due to conflicts". I pushed your changes to https://github.com/auto-pts/auto-pts/pull/1435 and there it seems to be just fine (same commits...), no idea why

I'll just merge that PR instead (it has all your commits untouched)

sjanc avatar Apr 02 '25 12:04 sjanc

those are failing on master too,

Thanks a lot for your explanation.

this looks good to be merge but github is getting bran-fart claiming that "This branch cannot be rebased due to conflicts". I pushed your changes to #1435 and there it seems to be just fine (same commits...), no idea why

Emm, actually, I also have rebased it.

I'll just merge that PR instead (it has all your commits untouched)

Sure. Please.

lylezhu2012 avatar Apr 02 '25 13:04 lylezhu2012

ok, so this is now merged (I had to split this into two PRs though, I guess github doesn't support such large rebases)

Please check if all is good

sjanc avatar Apr 02 '25 13:04 sjanc

ok, so this is now merged (I had to split this into two PRs though, I guess github doesn't support such large rebases)

Please check if all is good

Thanks a lot. All changes are in.

Could you please help review the changes of Zephyr tester https://github.com/zephyrproject-rtos/zephyr/pull/86822?

It is required your input, because there are some comments from @Thalley for you.

lylezhu2012 avatar Apr 02 '25 13:04 lylezhu2012

closing as all changes are in already

sjanc avatar Apr 09 '25 07:04 sjanc