ipex-llm icon indicating copy to clipboard operation
ipex-llm copied to clipboard

Chronos: Change TCNForecaster's default parameter num_channels to [16]*3

Open devWangBin opened this issue 2 years ago • 4 comments

Description

Chronos: Change TCNForecaster's default parameter of num_channels from [30]*7 to [16]*3

1. Why the change?

Based on experimental results on real datasets, we find that the parameter setting of [16]*3 generally have more stable and superior performance.

Github issue link: https://github.com/intel-analytics/BigDL/issues/5606

devWangBin avatar Sep 19 '22 13:09 devWangBin

I am pretty sure this should work, but we should be careful about this. @liangs6212 do you have any comments about this?

TheaperDeng avatar Sep 20 '22 14:09 TheaperDeng

I am pretty sure this should work, but we should be careful about this. @liangs6212 do you have any comments about this?

Can the same modification be used for TF2 TCNForecaster?

liangs6212 avatar Sep 21 '22 03:09 liangs6212

I am pretty sure this should work, but we should be careful about this. @liangs6212 do you have any comments about this?

Can the same modification be used for TF2 TCNForecaster?

Yeah, good catch. @devWangBin Please change bigdl.chronos.forecaster.tf.tcnforecaster as well

TheaperDeng avatar Sep 21 '22 07:09 TheaperDeng

Yeah, good catch. @devWangBin Please change bigdl.chronos.forecaster.tf.tcnforecaster as well

Okay, no problem.

devWangBin avatar Sep 21 '22 16:09 devWangBin

@plusbang @rnwang04 Since this default value is used everywhere so I am asking more stakeholders to have a review

TheaperDeng avatar Sep 26 '22 03:09 TheaperDeng

LGTM

rnwang04 avatar Sep 26 '22 03:09 rnwang04

LGTM

plusbang avatar Sep 26 '22 04:09 plusbang