terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

restrict_dismissals doesn't apply

Open bmrec opened this issue 3 years ago • 2 comments

Hi. When I run terraform apply terraform tries to change this:

~ required_pull_request_reviews {
          - restrict_dismissals             = true -> null

After applying, terraform offers to apply it again.

Terraform Version

Terraform v1.0.10 on linux_amd64

  • provider registry.terraform.io/hashicorp/github v4.12.0
  • provider registry.terraform.io/integrations/github v4.17.0

Affected Resource(s)

resource "github_branch_protection" "repos"

Expected Behavior

Apply the first time.

Actual Behavior

Doesn't apply.

bmrec avatar Nov 10 '21 08:11 bmrec

This is still an issue with terraform v1.1.2 in provider version v4.19.0

thekbb avatar Jan 25 '22 15:01 thekbb

I can confirm that this still happens with terraform ~>1.2 and provider version v4.28.0. There is any ETA for solving this? 🤔 thanks 🙇

srosell-ut avatar Aug 02 '22 12:08 srosell-ut

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

github-actions[bot] avatar Apr 30 '23 01:04 github-actions[bot]

We still experienced this issue at v5.28.1 It appears that the restrict_dismissals which is an optional field, is populated implicitly when you specify dismissal restrictions via other properties. The provider could have handled this for us, but specifying restrict_dismissals = true prevented the persistent plan changes.

ColinHarrington avatar Dec 13 '23 19:12 ColinHarrington