Deprecate and then remove has_downloads attribute on github_repository

[jtgrohn]

Affected Resource(s)

• github_repository

I think github_repository should not have a has_downloads attribute since it appears to be a deprecated property. The API still returns it, but it does not allow the value to be changed https://docs.github.com/en/rest/reference/repos#update-a-repository. I suspect the backend just throws that value out. Since it appears it isn't used, it should be deprecated and/or removed from the resource since its presence is misleading. I realize full removal is a breaking change, so maybe deprecation is the way to go for now?

I cannot find an announcement or release notes about this property to fully confirm.

[kfcampbell]

@jtgrohn I've searched around internally a bit in both code and docs/communication, and I can't find anything about this changing recently either.

I'm not quite convinced that the backend throws the value out; do you think you could come up with a repro case? Looking at the docs you linked, I see that the API accepts the value when creating a repo for an authenticated user, and returns it only after that. Perhaps the setting can only be set at creation time, and never altered?

[github-actions[bot]]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[Centzilius]

Maybe its a left over from this deprecation (from 11 years ago...) https://github.blog/2012-12-12-goodbye-uploads/

[GMZwinge]

Thanks to @Centzilius, I started the discussion in GitHub.