Migrate creation of repos from a template to the GraphQL API

[pmjacinto]

Fixes #836.

[pmjacinto]

Hey @jcudit can I get a review on this PR?

We've had to change to our forked version because of this issue, but we'd like to get back to the upstream version.

thanks!

[jcudit]

A couple of concerns with this one:

• We've had a large maintenance burden come out of switching to the v4 API for the branch protection resource and am concerned about introducing it further with such a popular resource.
• Our testing suite is not well equipped to exercise this change given the usage scenario of non-administrative access. Ideally, we'd grow that capability and revisit here with a stronger testing foundation.

We have an issue open to fix how our rate limiting operates with the v4 API. I'd like to revisit this feature once that is cleared up so we have better confidence with relying on the v4 API for more of our resources.

[pmjacinto]

hey, @jcudit thanks for the feedback, I see your point.

Just an update from my side: we've finally managed to test the provider with a GitHub app that has R&W permissions on everything and I can confirm that (as of 4.17.0) it is not possible to create repos from a template.

Error: PATCH https://api.github.com/repos/my-org/test-test-test3: 422 Visibility can't be changed by this user. []

[nickfloyd]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[github-actions[bot]]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!