terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Published 20 hours ago • verified publisher icon integrations

chore: Deprecated classic project resources

Open stevehipwell opened this issue 1 year ago • 2 comments

Resolves #2494

Before the change?

  • Resources using the removed classic projects REST API would not work and were not deprecated

After the change?

  • Resources using the removed classic projects REST API are deprecated

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [x] No

stevehipwell avatar Dec 06 '24 12:12 stevehipwell

In the meantime, the go-github SDK removed the (classic) projects API: https://github.com/google/go-github/releases/tag/v68.0.0

So maybe this could be removed entirely now?

0x46616c6b avatar Jun 02 '25 10:06 0x46616c6b

@0x46616c6b the intention here is/was to deprecate before removal as should have happened when the API was originally deprecated. Technically they were broken before I opened #2494 and should just be removed as their presence will block upgrading the SDK; but if a release is going out before the SDK is upgraded this PR is still valid. IMHO this PR should have been prioritised as it could have gone out in v6.5.0 or v6.6.0.

stevehipwell avatar Jun 03 '25 13:06 stevehipwell

@nickfloyd IMHO this should go into the codebase before the SDK is updated even if the SDK is updated and the files are removed before the next release.

stevehipwell avatar Oct 20 '25 17:10 stevehipwell

@nickfloyd IMHO this should go into the codebase before the SDK is updated even if the SDK is updated and the files are removed before the next release.

Agreed. I was sketching out what transitioning to the new project endpoints in GraphQL would look like and it's going to be a fairly significant change, let alone moving to the SDK @ v76. This type of comms is way over due. Thank you for making it happen ❤️

nickfloyd avatar Oct 21 '25 18:10 nickfloyd

@nickfloyd there is a REST API for projects now.

https://docs.github.com/en/rest/projects/projects?apiVersion=2022-11-28

stevehipwell avatar Oct 22 '25 09:10 stevehipwell

@nickfloyd there is a REST API for projects now.

🤦 You're right. Thank you for reminding me. ❤️

nickfloyd avatar Oct 22 '25 15:10 nickfloyd