terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard
verified publisher icon integrations

fix: Fixed branch protection v3 status checks churn

Open stevehipwell opened this issue 1 year ago • 4 comments

Resolves #2493

Before the change?

  • The github_branch_protection_v3 resource churned when when using checks or contexts in required_status_checks

After the change?

  • No churning on github_branch_protection_v3 resource

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [x] No

stevehipwell avatar Dec 05 '24 17:12 stevehipwell

Also seeing this behaviour, would be great to get this merged!

alexstojda avatar Jan 08 '25 18:01 alexstojda

Bump!

RobinOlofsson avatar Mar 05 '25 08:03 RobinOlofsson

Also hitting this. - maybe @kfcampbell can help?

joshmyers avatar Mar 26 '25 15:03 joshmyers

@kfcampbell @nickfloyd could you take a look please? this is very important to us and we would like to see this change made

KrawczowaKris avatar Jun 05 '25 09:06 KrawczowaKris

Bump 🙏🏼

joaorpsoares avatar Jul 07 '25 10:07 joaorpsoares

@joaorpsoares you'd probably be better off switching over to rulesets as they (mostly) work and don't have this churn issue.

stevehipwell avatar Jul 07 '25 12:07 stevehipwell

@nickfloyd this is a real pain point, albeit for a resource with a newer replacement. I could add a test to go with this, but I likely won't have time until the end of the week.

stevehipwell avatar Oct 20 '25 17:10 stevehipwell

@stevehipwell Tests have been added here https://github.com/integrations/terraform-provider-github/pull/2799

nickfloyd avatar Oct 21 '25 18:10 nickfloyd