terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Published 20 hours ago • verified publisher icon integrations

Return the error when deleting a file

Open frankywahl opened this issue 1 year ago • 1 comments

There is currently an issue when destroying the github_repository_file resource. If the action fails because of permissions, or because there is a protected branch, or any of the above, the error gets silenced.

Resolves #2464

Before the change?

  • Delete a github_repository_file would be successful even if the API call failed.

After the change?

  • A failed API call will not mark the apply as being successful

Does this introduce a breaking change?

  • [x] No (unless people are expecting that bad behavior).

frankywahl avatar Nov 14 '24 13:11 frankywahl

Could I get an update on this please? Maybe @nickfloyd - I saw you backloged the bug report (also - nice working back with you since NR)

frankywahl avatar May 26 '25 13:05 frankywahl

This was fixed in https://github.com/integrations/terraform-provider-github/pull/2837

frankywahl avatar Nov 06 '25 11:11 frankywahl