terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard
verified publisher icon integrations

feat: Add data source to retrieve repo environment public key

Open tiberium opened this issue 1 year ago • 1 comments

Resolves: Lack of a data source delivering a Public Key of a Repo's Environment

Before the change?

Not possible to retrieve the Public Key of a Environment in a Repository.

After the change?

Brand new data source delivering a Public Key created automatically by GitHub when a new Environment is created in a Repository.

  • Retrieving the organization public key, repository public key, user public key, dependabot public key and codespaces public key are already implemented. This PR brings the lacking Environment Public Key.

Pull request checklist

  • [X] Tests for the changes have been added (for bug fixes / features)
  • [X] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No breaking changes introduced.

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [X] No

tiberium avatar Aug 26 '24 18:08 tiberium

Hi @kfcampbell , sorry for the failing test, should work now. I added 2 new commits: one for the typo in docs, second one addressing the failing test. Should I squash everything into one commit and force-push here?

tiberium avatar Sep 05 '24 14:09 tiberium

Hi @kfcampbell , any chance to merge it?

tiberium avatar Aug 05 '25 08:08 tiberium

Hi @tiberium,

Sorry that you've had to wait on this so long. Would you be available resolve the merge conflicts?

After that we'll try to get this merged

deiga avatar Nov 28 '25 18:11 deiga

Hi @deiga , Thank you very much for getting back to me on this PR. I truly appreciate you taking the time to review it after such a long period.

To be honest, when I saw your message asking me to resolve the conflicts, I was very happy and excited that my contribution might finally be merged.

However, I have just noticed (while resolving the conflicts) that the exact same functionality was recently merged into the codebase by other contributors about three weeks ago, specifically in PR #2500. The other authors created the PR months after me, but were faster to merge it. Yeah, life, good for them and the project! :)

Given the circumstances, I am closing this Pull Request.

Thank you again for your time and the opportunity to contribute. I look forward to contributing other useful features in the future!

tiberium avatar Nov 29 '25 10:11 tiberium

I'm sorry that happened to you 😕 We're hopefully better in the future in getting contributions merged and triaging duplicates.

Looking forward for any new additions from you ☺️

deiga avatar Nov 29 '25 10:11 deiga