terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard
verified publisher icon integrations

feat: add github_user_ssh_signing_key

Open simonostendorf opened this issue 1 year ago • 4 comments

Resolves #2365

Resolves #1917

Before the change?

  • managing ssh signing keys was not possible

After the change?

  • managing ssh signing keys is possible with github_user_ssh_signing_key resource
  • the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [x] No

simonostendorf avatar Aug 26 '24 01:08 simonostendorf

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

kfcampbell avatar Aug 30 '24 20:08 kfcampbell

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

simonostendorf avatar Aug 31 '24 06:08 simonostendorf

#1917 should perhaps be formally linked to this PR as well since it appears equivalent to #2365

quotidian-ennui avatar Oct 16 '24 09:10 quotidian-ennui

@kfcampbell hey, can we get this merged?

simonostendorf avatar May 28 '25 05:05 simonostendorf

Would love to see this merged

kilianpaquier avatar Oct 10 '25 18:10 kilianpaquier