terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

feat: support team organization role assignment

Open felixlut opened this issue 1 year ago • 0 comments

Resolves #2314


Before the change?

  • It was not possible to assign an organization role to a team with the Terraform provider

After the change?

  • Implemented a github_team_organization_role_assignment resource which is used to assign an organization role to a team
  • I've added the octokit/go-sdk since google/go-github lacked support for assigning a role to a team as far as I could see. go-github is still being used for this resource though, as go-sdk lacks support for pagination (https://github.com/microsoft/kiota/issues/4698), which is needed in the READ implementation
    • This is the reason for the big number of changes in the PR, the go packages, including the vendor, has changed. View the PR in Firefox if the Files changed tab lags... https://github.com/orgs/community/discussions/39341

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [x] No, this is a brand new resource

felixlut avatar Jul 17 '24 14:07 felixlut