terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Fix 5.43 upgrade signoff

Open bzarboni1 opened this issue 10 months ago • 3 comments

Resolves #I2077


Before the change?

  • For a repository update, there's a bug in the GitHub 2022-11-28 version, that throws a 422 error whenever the web_commit_signoff_required is set to true, even when it is already true.

After the change?

  • On a repository update, we check if the web_commit_signoff_required has been modified. If it has, it is passed along in the request. If it hasn't, it is silently dropped from the request.

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [x] No

bzarboni1 avatar Apr 08 '24 13:04 bzarboni1