terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Published 20 hours ago • verified publisher icon integrations

[MAINT]: Bump go-github to v60

Open nayuta opened this issue 1 year ago • 4 comments
trafficstars

Describe the need

Bump go-github from v57 to v60

This bump has some breaking changes to fix.

  • In V60
    • https://github.com/google/go-github/pull/3070
    • https://github.com/google/go-github/pull/3073

These changes seem to feature changes and bug fixes but need triage.

  • In V59
    • https://github.com/google/go-github/pull/3049
    • https://github.com/google/go-github/pull/3023
  • In v58
    • https://github.com/google/go-github/pull/3017

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

nayuta avatar Mar 07 '24 08:03 nayuta

@kfcampbell I already created the PR for this. Could you tell me about the next step?

nayuta avatar Mar 14 '24 06:03 nayuta

Hi, thanks for doing that. What happens next is @nickfloyd or I will review it when we can, which is usually (but not always) a Monday or a Friday. Please be patient, we don't get as much time as we'd like to do this. Thank you for contributing!

kfcampbell avatar Mar 14 '24 16:03 kfcampbell

Hi, thanks for replying. I got about the situation. I'm always grateful to you for maintaining the repository!

nayuta avatar Mar 15 '24 08:03 nayuta

hey @kfcampbell, hope you're having a good week. Quick question, is this something that you'll be looking at soon? I only ask because it seems to be holding up the Custom Properties tf provider which we're super-keen to use! https://github.com/integrations/terraform-provider-github/issues/1956

JamieB101 avatar Jun 18 '24 08:06 JamieB101

Closing this issue as #2304 has been merged.

kfcampbell avatar Jul 03 '24 20:07 kfcampbell