terraform-provider-github
terraform-provider-github copied to clipboard
fix: error if autolink reference not found
Resolves #2163
Before the change?
- panic when importing invalid autolink reference
After the change?
- throws an error as expected
Pull request checklist
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
- [ ] Yes
- [ ] No
Would it be possible to write a test for this case? Could you also describe how you've manually tested this scenario?
Yeah I can whip up a test in the next day or so.
I built the provider locally and used it with our GHES instance with a TF_CLI_CONFIG_FILE
envvar.
GITHUB_BASE_URL=https://ourgithub.int GITHUB_TOKEN=redacted GITHUB_ORGANIZATION=test GITHUB_OWNER=test TF_ACC=1 go test -v ./... -run ^TestAccGithubRepositoryAutolinkReference
? github.com/integrations/terraform-provider-github/v6 [no test files]
=== RUN TestAccGithubRepositoryAutolinkReferencesDataSource
=== RUN TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references
=== RUN TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_anonymous_account
data_source_github_repository_autolink_references_test.go:61: anonymous account not supported for this operation
=== RUN TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_individual_account
=== RUN TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_organization_account
--- PASS: TestAccGithubRepositoryAutolinkReferencesDataSource (36.15s)
--- PASS: TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references (36.15s)
--- SKIP: TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_anonymous_account (0.00s)
--- PASS: TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_individual_account (18.16s)
--- PASS: TestAccGithubRepositoryAutolinkReferencesDataSource/queries_autolink_references/with_an_organization_account (17.99s)
=== RUN TestAccGithubRepositoryAutolinkReference
=== RUN TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error
=== RUN TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_anonymous_account
resource_github_repository_autolink_reference_test.go:113: anonymous account not supported for this operation
=== RUN TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_individual_account
=== RUN TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_organization_account
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_anonymous_account
resource_github_repository_autolink_reference_test.go:251: anonymous account not supported for this operation
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_individual_account
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_organization_account
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_anonymous_account
resource_github_repository_autolink_reference_test.go:306: anonymous account not supported for this operation
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_individual_account
=== RUN TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_organization_account
=== RUN TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error
=== RUN TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_anonymous_account
resource_github_repository_autolink_reference_test.go:350: anonymous account not supported for this operation
=== RUN TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_individual_account
=== RUN TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_organization_account
--- PASS: TestAccGithubRepositoryAutolinkReference (143.88s)
--- PASS: TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error (40.45s)
--- SKIP: TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_anonymous_account (0.00s)
--- PASS: TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_individual_account (20.16s)
--- PASS: TestAccGithubRepositoryAutolinkReference/creates_repository_autolink_reference_without_error/with_an_organization_account (20.29s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error (55.88s)
--- SKIP: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_anonymous_account (0.00s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_individual_account (27.41s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_without_error/with_an_organization_account (28.47s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error (35.35s)
--- SKIP: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_anonymous_account (0.00s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_individual_account (16.89s)
--- PASS: TestAccGithubRepositoryAutolinkReference/imports_repository_autolink_reference_by_key_prefix_without_error/with_an_organization_account (18.46s)
--- PASS: TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error (12.20s)
--- SKIP: TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_anonymous_account (0.00s)
--- PASS: TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_individual_account (6.15s)
--- PASS: TestAccGithubRepositoryAutolinkReference/deletes_repository_autolink_reference_without_error/with_an_organization_account (6.04s)
PASS
ok github.com/integrations/terraform-provider-github/v6/github 180.140s