terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

[FEAT]: Add support for GitHub Advanced Security features

Open samtarplee opened this issue 1 year ago • 7 comments

Describe the need

Github Advanced Security provides a lot of features, such as secret scanning, code scanning, and more expansive Dependabot management. Being able to manage these features for a GitHub organisation at scale using Terraform would be very useful, particularly the secret scanning, which can support custom patterns.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

samtarplee avatar Dec 04 '23 09:12 samtarplee

What specifically do you need? I currently use the following GitHub Advanced Security features in my code:

resource "github_repository" "symbolic_name" {
  
  vulnerability_alerts = true

  security_and_analysis {
    advanced_security {
      status = "enabled"
    }
    secret_scanning {
      status = "enabled"
    }
    secret_scanning_push_protection {
      status = "enabled"
    }
  }
}

resource "github_repository_dependabot_security_updates" "symbolic_name" {
  enabled = true
}

nnellanspdl avatar Dec 15 '23 17:12 nnellanspdl

@nnellanspdl Being able to manage custom patterns for secret scanning is the main one I'd like, as well as managing the above options on an organisation level.

samtarplee avatar Dec 19 '23 11:12 samtarplee

I agree - having the ability to configure these options on an organizational level would be extremely useful for the Effect-TS GitHub organization.

IMax153 avatar Dec 21 '23 14:12 IMax153

Is this supported in the API? I'm not seeing it.

kfcampbell avatar Jan 05 '24 19:01 kfcampbell

@kfcampbell I can't see it either. Is there a way to raise a feature request for the GitHub API itself?

samtarplee avatar Jan 15 '24 16:01 samtarplee

@samtarplee You might try asking for the feature in the community API discussions.

kfcampbell avatar Jan 22 '24 19:01 kfcampbell

Would love to also see the ability to manage:

  1. Scan for non-provider patterns
  2. Use AI detection to find additional secrets
  3. Validity checks
  4. Autofix for CodeQL

ChristopherMank avatar Jul 23 '24 17:07 ChristopherMank