Team reviewers exclusions

[felixlut]

trafficstars

Resolves #1972

---

Before the change?

• It's not possible to alter the exclusion list for team members that shouldn't be added as reviews to pull requests via the terraform provider

After the change?

• It's now possible to alter the exclusion list for team members that shouldn't be added as reviews to pull requests via the terraform provider

Pull request checklist

• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

• [ ] Yes
• [x] No

---

[felixlut]

@kfcampbell I started working on adding functionality for this issue and quickly realized that it's currently limited by the API, which is currently in preview. While it's possible to to SET the exclusion list, it's not possible to read it. This leads to terraform never being able to make proper plans, since the exclusion list always will be empty from the providers perspective:

My question now is whether you're able to ask around to see what the maturity plan is for the GitHub team GraphQL API is? I could spend some time trying to work around the issue, but the "proper" solution is just for the read of the exclusion list to be added to the API. If that's upcoming in the pipeline, I don't think whatever hack I come up with is the way to solve it.

It seems like it's been in preview since at least 2020-01-14, which is when the Team preview was added to the docs of Enterprise Server 2.20 (it's nowhere to be found on the same page for 2.19). Would be nice to know what the status of the preview is 😅

[kfcampbell]

the "proper" solution is just for the read of the exclusion list to be added to the API

I totally agree with you. I don't think it's worth hacking around until it's available in the API. Unfortunately I don't have any insight as to the plan there. Logging a public request here is probably the best bet.

[felixlut]

I've added a discussion about it here: https://github.com/orgs/community/discussions/72860

[Rowern]

Hello, just saw some activity on the discussion page, do you know if this is mergeable @felixlut ? This would be very helpful to be able to manage those settings via the provider.

[felixlut]

@Rowern no, sadly it's not in a mergeable state. A month or so ago I got back to this and checked again if the API needed for this feature was available now, as the reply to my discussion suggested. It was not. It isn't now. The API is no longer in preview though, which is something.

I've tried reaching out again here, but haven't seen an update since.

[github-actions[bot]]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!