terraform-provider-github
terraform-provider-github copied to clipboard
integrations
fix: find correct permission
With this PR you are removing the support for custom role permissions, am I right? We were waiting for the support of custom roles and then the PR was reverted, there's a way to make it work and keep the retrocompatibility?
@joshua-hancox @kfcampbell any news? this is blocking us from adopting this provider
We're also interested in having this fix available - quiet confusing to see TF plans that always report changes when using custom roles.
Hey @joshua-hancox I'd be glad to resolve those merge conflicts for you to move this along if you'd like. I'll need push or maintainer access to joshua-hancox:main, though so that we can get your fork synced with this repo. Let us know if you'd like us to handle that or if you'd be up for doing it!
@kfcampbell I don't believe that was part of my change here, sorry it's been ages since I looked at this.
@nickfloyd I doubt I have any time to look at this any time soon, I have added you as collaborator please feel free to carry on.
From my understanding this PR https://github.com/integrations/terraform-provider-github/pull/1192 was good but didn't consider backwards compatibility. May I propose to release a new major with those changes or add some kind of mapping to preserve old naming compatibility? Sooner or later I think this provider should move to the new API version
Sorry @kfcampbell I don't think I will get time to look at this any time soon, if you'd like to please feel free to carry on, or I think @nickfloyd also planned to take a look at it.
Sounds good! I've added the "Status: Up for grabs" label so the community can jump on the submission if anybody can get to it sooner rather than later.
Oops, I accidentally "closed with comment" with a single g in the comment field. Now the body of this comment can't be blank.