terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Use GetRoleName() instead of permission mapping not backward compatible.

Open schans opened this issue 2 years ago • 2 comments

Hi there,

Terraform Version

4.27.0

Affected Resource(s)

  • resource_github_team_repository

Expected Behavior

Things keep working as in <4.27.0

Actual Behavior

Non-custom roles are broken as the naming is different. read vs pull, write vs push etc. For a lot more info see: https://github.com/integrations/terraform-provider-github/pull/1192

Steps to Reproduce

Upgrade from <4.27.0 to 4.27.0 and run tf apply

Important Factoids

Seems a bit of a mess due to historic reasons as Github? https://github.community/t/is-the-api-insane-with-respect-to-collaborators-or-am-i-confused/253696

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

  • GH-1192

schans avatar Jul 18 '22 15:07 schans

Many thanks @kfcampbell. Given that we've successfully reverted PR #1192 , should we close this issue and open a new one regarding the original broken behaviour when using custom roles?

Luis-3M avatar Aug 04 '22 09:08 Luis-3M

That sounds good to me! I've chosen to reopen #1183.

kfcampbell avatar Aug 26 '22 23:08 kfcampbell