terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

[Feature Request] support for the Github "Security Managers" feature

Open Svetlanko opened this issue 2 years ago • 1 comments

are there plans to add support for a Github "Security Managers" feature? https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization

we've been configuring it manually via Github UI but would love to have it terraformed.

thank you!

Svetlanko avatar Jun 29 '22 18:06 Svetlanko

Yes, this would be a great feature.

SolomonHD avatar Aug 11 '22 18:08 SolomonHD

This will need support for the security managers API. Created https://github.com/google/go-github/issues/2529 to track.

I'm happy to pick this up too. 👍

jeremyhayes avatar Oct 25 '22 19:10 jeremyhayes

Thank you @jeremyhayes! You rock. Please let me know if you'd like my eyes, assistance, etc.

kfcampbell avatar Oct 27 '22 21:10 kfcampbell

Quick status update. The necessary change in the underlying API client was merged.

  • https://github.com/google/go-github/pull/2530

Now waiting on a release of that lib and for it to get updated here.

jeremyhayes avatar Nov 02 '22 13:11 jeremyhayes

Thanks for the update! Still waiting on a release of go-github unfortunately.

kfcampbell avatar Nov 10 '22 19:11 kfcampbell

Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?

SolomonHD avatar Nov 14 '22 22:11 SolomonHD

Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?

My WIP has it as a new resource: github_organization_security_manager. But certainly that's up for debate when the PR opens! 😅

jeremyhayes avatar Nov 14 '22 22:11 jeremyhayes

go-github v48.1.0 has released with the needed API support.

@kfcampbell what's the preferred update path here? ~~Looks like we're still on v47.~~ incorrect, my fork is out of date 🙃

jeremyhayes avatar Nov 15 '22 22:11 jeremyhayes

Hey @jeremyhayes, I'm on it... I'll update the dep and drop a PR (reference it here).

nickfloyd avatar Nov 16 '22 19:11 nickfloyd

For reference: go-github version update PR

nickfloyd avatar Nov 16 '22 19:11 nickfloyd

thank you for getting this feature out 🔥

Svetlanko avatar Dec 02 '22 00:12 Svetlanko