terraform-provider-github
terraform-provider-github copied to clipboard
[Feature Request] support for the Github "Security Managers" feature
are there plans to add support for a Github "Security Managers" feature? https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization
we've been configuring it manually via Github UI but would love to have it terraformed.
thank you!
Yes, this would be a great feature.
This will need support for the security managers API. Created https://github.com/google/go-github/issues/2529 to track.
I'm happy to pick this up too. 👍
Thank you @jeremyhayes! You rock. Please let me know if you'd like my eyes, assistance, etc.
Quick status update. The necessary change in the underlying API client was merged.
- https://github.com/google/go-github/pull/2530
Now waiting on a release of that lib and for it to get updated here.
Thanks for the update! Still waiting on a release of go-github unfortunately.
Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?
Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?
My WIP has it as a new resource: github_organization_security_manager
. But certainly that's up for debate when the PR opens! 😅
go-github v48.1.0 has released with the needed API support.
@kfcampbell what's the preferred update path here? ~~Looks like we're still on v47.~~ incorrect, my fork is out of date 🙃
Hey @jeremyhayes, I'm on it... I'll update the dep and drop a PR (reference it here).
For reference: go-github version update PR
thank you for getting this feature out 🔥