terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

[Feature Request] GitHub Advanced Security

Open tjcorr opened this issue 3 years ago • 9 comments

Support for GitHub Advanced Security and Secret Scanning.

The current repository resource does not support the parameter: security_and_analysis which is used to enable both GHAS and secret scanning on a repository:

Specify which security and analysis features to enable or disable. For example, to enable GitHub Advanced Security, use this data in the body of the PATCH request: {"security_and_analysis": {"advanced_security": {"status": "enabled"}}}. If you have admin permissions for a private repository covered by an Advanced Security license, you can check which security and analysis features are currently enabled by using a GET /repos/{owner}/{repo} request.

This parameter is already supported in the go library with https://github.com/google/go-github/issues/2132 .

tjcorr avatar Apr 05 '22 13:04 tjcorr

+1 I could use this now.

cfisher281 avatar Jun 08 '22 16:06 cfisher281

any news on this?

lagerfeuer avatar Jul 07 '22 18:07 lagerfeuer

BUMP..........

skumarnara avatar Jul 07 '22 18:07 skumarnara

Could also really use this.

andrew-lethbridge-vgh avatar Aug 03 '22 18:08 andrew-lethbridge-vgh

This would be a useful feature.

jwfh avatar Aug 03 '22 18:08 jwfh

Would really like this feature. Right now our repo creation process is not fully automatable without this change to the provider.

Dilfer avatar Aug 03 '22 18:08 Dilfer

https://github.com/integrations/terraform-provider-github/pull/1298 allows us to set the GHAS settings on an org level. I will investigate how to implement this at the repo level.

kuhlman-labs avatar Sep 21 '22 21:09 kuhlman-labs

There was an additional field added to the Security and Analysis block to configure secret scanning push protection. I have a PR open https://github.com/google/go-github/pull/2476 to add the field and then I can configure the repository resource.

kuhlman-labs avatar Sep 22 '22 14:09 kuhlman-labs

@kuhlman-labs you are a scholar and a gentleman. This is exciting news!

andrew-lethbridge-vgh avatar Sep 22 '22 14:09 andrew-lethbridge-vgh

PR has been submitted: https://github.com/integrations/terraform-provider-github/pull/1304

kuhlman-labs avatar Sep 26 '22 18:09 kuhlman-labs

Looking forward to this one 🚀

Luis-3M avatar Sep 29 '22 15:09 Luis-3M

This feature has been merged, @kfcampbell / @nickfloyd this Issue can be closed.

kuhlman-labs avatar Nov 21 '22 14:11 kuhlman-labs