terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

feature request: Add support for 'public' attribute on github pages configuration

Open pkwarren opened this issue 3 years ago • 13 comments

We'd like to use the Github pages functionality of the terraform provider, however currently it doesn't support the github pages 'public' option: https://github.com/google/go-github/blob/178169fc04bc4a05ca48f98709cdd02ab5b556e3/github/repos_pages.go#L21

Terraform Version

v1.1.4

Affected Resource(s)

  • github_repository

Terraform Configuration Files

resource "github_repository" "example" {
  name        = "example"
  description = "My awesome web page"
  private = true
  pages {
    source {
      branch = "main"
      path   = "/docs"
    }
    # TODO: Doesn't work
    public = false
  }
}

Expected Behavior

Should be able to configure 'public = false' to limit visibility of github pages.

Actual Behavior

Option not yet supported.

pkwarren avatar Jan 21 '22 18:01 pkwarren

It looks like this will require fixes to upstream GitHub module: https://github.com/google/go-github/issues/2261

pkwarren avatar Jan 21 '22 18:01 pkwarren

Looks like it has been included upstream and will be included in the next release

btkostner avatar Jan 28 '22 19:01 btkostner

go-github has released v43.0.0 which includes the fix here https://github.com/google/go-github/releases/tag/v43.0.0

btkostner avatar Mar 07 '22 19:03 btkostner

This issue should not yet be closed

btkostner avatar Apr 11 '22 16:04 btkostner

Oh I'm sorry! Thanks for catching this @btkostner.

kfcampbell avatar Apr 28 '22 21:04 kfcampbell

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

github-actions[bot] avatar Jan 24 '23 02:01 github-actions[bot]

Currently waiting for PR to merge

btkostner avatar Jan 24 '23 02:01 btkostner

We need this feature! 🙏🏻

ViacheslavKudinov avatar Feb 17 '23 20:02 ViacheslavKudinov

image

dweaver33 avatar Apr 07 '23 13:04 dweaver33

Any updates on this?

calebworks avatar Sep 21 '23 03:09 calebworks

Hello, any updates or was it implemented ?

ViacheslavKudinov avatar Apr 08 '24 14:04 ViacheslavKudinov

What else is needed to make this feature available?

Luis-3M avatar Aug 21 '24 14:08 Luis-3M

It looks like the upstream lower level API library has this feature released now. Someone just needs to open the PR for it in the terraform provider.

btkostner avatar Aug 21 '24 16:08 btkostner

I could use this feature too 👍

lbartolotti-gocity avatar Jan 17 '25 13:01 lbartolotti-gocity

Hello, I've give this feature request a go, anyone know if I have to poke someone to get it reviewed or is just a matter of waiting? https://github.com/integrations/terraform-provider-github/pull/2540

BartolottiLuca avatar Jan 20 '25 11:01 BartolottiLuca

+1 Would like this feature

pdewilde avatar Aug 14 '25 20:08 pdewilde