terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Published 20 hours ago • verified publisher icon integrations

Allow setting owner in anonymous mode

Open kfcampbell opened this issue 3 years ago • 3 comments

Fixes #647.

The provider currently doesn't respect any ownership configuration when running in anonymous mode. This is annoying because it blocks all kinds of uses, for example data sources retrieving public repos.

This PR makes a small change to respect ownership in anonymous mode, and now those data sources work!

kfcampbell avatar Jan 08 '22 17:01 kfcampbell

cc @Olin-Vorechovsky I'd rather do this than error if there's no token present, since there's a lot of valid use cases for the provider without auth configured IMO. Thoughts?

kfcampbell avatar Jan 08 '22 17:01 kfcampbell

I think this is a worthwhile change and since it's not breaking backwards compatibility, I've added it to a future milestone for release.

kfcampbell avatar Jan 31 '22 04:01 kfcampbell

@jcudit let's talk about this in the next week or two!

kfcampbell avatar Mar 03 '22 21:03 kfcampbell

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

nickfloyd avatar Nov 30 '22 16:11 nickfloyd

I had forgotten about this! I think this is still relevant and should be merged.

kfcampbell avatar Dec 01 '22 19:12 kfcampbell