slack icon indicating copy to clipboard operation
slack copied to clipboard

subscribe to PR approvals

Open ghostsquad opened this issue 5 years ago • 47 comments
trafficstars

Is there anyway to show when a PR is approved?

ghostsquad avatar Jan 31 '20 01:01 ghostsquad

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

welcome[bot] avatar Jan 31 '20 01:01 welcome[bot]

Yes, the new Scheduled Reminders beta functionality does this. Sign up for the beta preview and it will be enabled for your organization as soon as we add more to the feature flag!

tebriel avatar Jan 31 '20 14:01 tebriel

I've read the documentation for the Scheduled Reminders: https://hoverinc.atlassian.net/wiki/spaces/EPD/pages/2135883874/2021-04-12+Oauth+BE+Tech+Spec#GraphQL-response-format

I see a section that shows how to ignore Approved PRs, but I don't see anything specifically that shows how to be notified when a PR has been fully approved and is in a "Ready To Merge" state.

Screen Shot 2021-04-16 at 4 38 10 PM

Is there some part of this feature that could directly DM the PR author when their PR is approved/ready to merge?

don-hover avatar Apr 16 '21 20:04 don-hover

+1

I'd really like the option to be notified by Slack message when my PR is approved

martha-truesource avatar Jul 26 '21 21:07 martha-truesource

👍

pgollucci avatar Jul 29 '21 00:07 pgollucci

It would be really useful if it comes out of the box from the integration :+1:

martin056 avatar Aug 25 '21 06:08 martin056

Is there any update on this feature?

JCMais avatar Jan 18 '22 14:01 JCMais

This feature will really help me as well :)

ido-hunters avatar Jan 26 '22 11:01 ido-hunters

Please implement this feature

jonbeacherdomuso avatar Apr 15 '22 19:04 jonbeacherdomuso

This would be a really great feature for my company as well. I spend so much time refreshing Github just to see if my PR is merged yet, and getting notified upon approval would be much more efficient.

smacilwaine avatar May 02 '22 20:05 smacilwaine

Same here, I think it's as important as being notified when a new PR is opened.

matiasf9 avatar May 09 '22 20:05 matiasf9

+1

filip-sakalos avatar May 18 '22 13:05 filip-sakalos

+1 for this feature. Would also like to know if new review is posted on your PR. Currently I only get notified when PR is created and merged:(

prabhushrikant avatar Jun 05 '22 16:06 prabhushrikant

+1

giulitn avatar Jul 11 '22 16:07 giulitn

+1

danielpatricio-wa avatar Jul 14 '22 15:07 danielpatricio-wa

+10000

DannyC-BC avatar Jul 21 '22 16:07 DannyC-BC

+1

nandastone avatar Aug 04 '22 02:08 nandastone

+1

BuddhaBing avatar Aug 08 '22 13:08 BuddhaBing

Please add this

jonnywyatt avatar Sep 14 '22 18:09 jonnywyatt

+1

slapart avatar Oct 21 '22 13:10 slapart

+1

michaelignat avatar Nov 04 '22 06:11 michaelignat

+1

amir-tastewise avatar Nov 09 '22 12:11 amir-tastewise

checking in to see if this issue has been triaged at all? I don't see it mentioned in the current road map and we cannot do it ourselves as you all are no longer accepting code contributions.

thanks!

alishaevn avatar Nov 09 '22 18:11 alishaevn

Still hoping to see this

mikemaring avatar Dec 16 '22 03:12 mikemaring

Need the feature as well

foamzou avatar Jan 04 '23 02:01 foamzou

+1

noahtf13 avatar Jan 09 '23 16:01 noahtf13

+1

deweyredman avatar Jan 11 '23 17:01 deweyredman

+1 definitely need the feature as well...

muratdozen avatar Jan 23 '23 15:01 muratdozen

+1

dav-pascual avatar Feb 22 '23 10:02 dav-pascual

+1

kelvinsanchez15 avatar Mar 07 '23 16:03 kelvinsanchez15