slack
slack copied to clipboard
[Feature Request] Create notification on label change
In our Slack integration we limit notifications to a certain label. Creating the PR and then changing the label doesn't trigger a notification. It doesn't even trigger the notification if you add a comment later.
Here are the steps to recreate the problem:
- subscribe to a repo with +label:ready-for-review
- create a PR without a label
- attach the label "ready-for-review"
- notice that there is no notification in Slack for this PR
- update the PR comment
- notice that there is still no notification in Slack for this PR
NOTE: This is similar to these issues: #963, #961, #832
Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.
This is especially important for OSS projects where contributors have no permissions to add labels and labels have to be added by maintainers after the PR/issue is created. I expect that when a maintainer gets to the PR/issue to triage it and adds a label, that a slack notification also gets sent to notify the rest of the team.
We also use this method in our project. It would be great to have this feature.
I second that, this will be very helpful.
The lack of this feature is currently blocking us from using the slack integration. We work in a monorepo, and have a bot that auto-adds labels based on the team and directory. Since that bot runs after the PR is opened (a couple of seconds), the notification isnt sent.
I have also tried adding the label upon opening the PR, using the gh
cli by running gh pr create -f -l "ready-for-review"
, but it is still not sending a notification in this case.
I wrote the patch for this issue in #1058. Please help it to merge 🙌
Up for this one, it will be really helpful to be integrated ;)
Up, really wish this moved forward :)
Up
Up
Up - currently my team uses a home-rolled integration as a workaround. Would be nice if we could just use this integration for it all
Up - currently my team uses a home-rolled integration as a workaround. Would be nice if we could just use this integration for it all
Same here, we are using custom in-house solution for this simple feature. I would be glad even to implement this logic by my own, but unfortunately
This repository is not accepting any code contributions.
UP
Up, really missing this one!
Up
Up!
up!
not ideal but a work around I found useful is adding labels, converting PR to a draft, then back will trigger the notifications w/ the new labels
CS Release Readiness is interested in this feature - we have a Slack integration that posts new Release Readiness Checklists from https://github.com/github/CS-Release-Readiness/issues into a Slack channel (#cs-release-readiness
) for visibility to CS teams, but anyone immediately clicking the link will see a blank template. These checklists only have value when they are triaged by the CS Release Readiness team. This does typically happen quickly, but the real value add would be for these checklists to be posted into our Slack channel when our Triage Completed
label is applied. This label indicates that the checklist is completed - it's filled out with source documents and other materials that are essential for Support and other CS teams to support our customers.