slack icon indicating copy to clipboard operation
slack copied to clipboard

[Feature Request] Create notification on label change

Open rnhurt opened this issue 5 years ago • 19 comments

In our Slack integration we limit notifications to a certain label. Creating the PR and then changing the label doesn't trigger a notification. It doesn't even trigger the notification if you add a comment later.

Here are the steps to recreate the problem:

  1. subscribe to a repo with +label:ready-for-review
  2. create a PR without a label
  3. attach the label "ready-for-review"
  4. notice that there is no notification in Slack for this PR
  5. update the PR comment
  6. notice that there is still no notification in Slack for this PR

NOTE: This is similar to these issues: #963, #961, #832

rnhurt avatar Nov 22 '19 08:11 rnhurt

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

welcome[bot] avatar Nov 22 '19 08:11 welcome[bot]

This is especially important for OSS projects where contributors have no permissions to add labels and labels have to be added by maintainers after the PR/issue is created. I expect that when a maintainer gets to the PR/issue to triage it and adds a label, that a slack notification also gets sent to notify the rest of the team.

alvin-huang avatar Mar 09 '20 15:03 alvin-huang

We also use this method in our project. It would be great to have this feature.

zyqxd avatar Mar 27 '20 16:03 zyqxd

I second that, this will be very helpful.

mariskapansegrauw avatar May 08 '20 15:05 mariskapansegrauw

The lack of this feature is currently blocking us from using the slack integration. We work in a monorepo, and have a bot that auto-adds labels based on the team and directory. Since that bot runs after the PR is opened (a couple of seconds), the notification isnt sent.

I have also tried adding the label upon opening the PR, using the gh cli by running gh pr create -f -l "ready-for-review", but it is still not sending a notification in this case.

adamochayon avatar Jun 19 '20 20:06 adamochayon

I wrote the patch for this issue in #1058. Please help it to merge 🙌

otoyo avatar Aug 06 '20 23:08 otoyo

Up for this one, it will be really helpful to be integrated ;)

GeekPress avatar Feb 14 '21 18:02 GeekPress

Up, really wish this moved forward :)

jokvar avatar Jun 05 '21 07:06 jokvar

Up

kiba-d avatar Dec 30 '21 13:12 kiba-d

Up

sagilaufer1992 avatar Mar 03 '22 15:03 sagilaufer1992

Up - currently my team uses a home-rolled integration as a workaround. Would be nice if we could just use this integration for it all

jebbers-togogroup avatar May 03 '22 17:05 jebbers-togogroup

Up - currently my team uses a home-rolled integration as a workaround. Would be nice if we could just use this integration for it all

Same here, we are using custom in-house solution for this simple feature. I would be glad even to implement this logic by my own, but unfortunately

This repository is not accepting any code contributions.

UP

bmwant avatar Jul 12 '22 14:07 bmwant

Up, really missing this one!

IwonaSobieraj avatar Aug 23 '22 10:08 IwonaSobieraj

Up

edverma avatar Sep 21 '22 14:09 edverma

Up!

suvir-c avatar Sep 23 '22 16:09 suvir-c

up!

ransarusi avatar Oct 06 '22 11:10 ransarusi

not ideal but a work around I found useful is adding labels, converting PR to a draft, then back will trigger the notifications w/ the new labels

dags2112 avatar Nov 29 '22 16:11 dags2112

CS Release Readiness is interested in this feature - we have a Slack integration that posts new Release Readiness Checklists from https://github.com/github/CS-Release-Readiness/issues into a Slack channel (#cs-release-readiness) for visibility to CS teams, but anyone immediately clicking the link will see a blank template. These checklists only have value when they are triaged by the CS Release Readiness team. This does typically happen quickly, but the real value add would be for these checklists to be posted into our Slack channel when our Triage Completed label is applied. This label indicates that the checklist is completed - it's filled out with source documents and other materials that are essential for Support and other CS teams to support our customers.

Richard-Saunders avatar Dec 14 '22 16:12 Richard-Saunders