slack icon indicating copy to clipboard operation
slack copied to clipboard

Notifications on re-requested PR review

Open annatfw opened this issue 5 years ago • 18 comments

A recent feature allows re-requesting review after changes are made, which notifies the reviewers.

https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/

Slack integration that would either notify reviewers, or (ideally; if possible at all) notify any subscriber that review for this PR has been re-requested would be greatly helpful.

annatfw avatar Apr 02 '19 14:04 annatfw

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

welcome[bot] avatar Apr 02 '19 14:04 welcome[bot]

When can this accomplished? I'm looking forward to this.

keithhan-nsuslab avatar Jan 02 '20 12:01 keithhan-nsuslab

It would be very nice to have this, Pull Panda have it, I have it but my coworkers cant use it because Pull Panda closed the doors joining github.

danielgomezrico avatar Mar 03 '20 21:03 danielgomezrico

This feature would be great to speed up the dev pipeline, especially for remote work!

bombillazo avatar Oct 22 '20 12:10 bombillazo

+1

egemon avatar Mar 12 '21 10:03 egemon

We started using https://github.com/manosim/gitify and is totally awesome

danielgomezrico avatar Mar 12 '21 10:03 danielgomezrico

+1 We could really use this feature too

andresovela avatar Mar 31 '21 14:03 andresovela

We started using https://github.com/manosim/gitify and is totally awesome

Good alternative. But It seems to not support detailed notification setting. It means that I can't subscribe re-requested notification without anything else.

keithhan-nsuslab avatar Apr 01 '21 04:04 keithhan-nsuslab

+1 Really miss this feature now that Pull Panda is dead.

frankiea avatar May 06 '21 00:05 frankiea

+1 Our re-requested PR reviews often stall an unnecessary amount of time, as most interactions are notified on Slack excepting this one.

hblanko avatar Aug 19 '21 11:08 hblanko

+1 we resort back to manually pinging people to re-review pull requests :(

holsky-hivebuy avatar Sep 07 '21 15:09 holsky-hivebuy

+1

filipszczepanski avatar Nov 05 '21 13:11 filipszczepanski

+1

dw2kim avatar Nov 17 '21 17:11 dw2kim

+1

rusik avatar Nov 23 '21 10:11 rusik

+1

ebk46 avatar Dec 22 '21 00:12 ebk46

I appreciate that people would like to +1 interest on this, but please use reactji on the original ask instead of adding a new comment to the thread.

Maybe the maintainers should lock this issue to prevent new comments.

jamietanna avatar Dec 22 '21 08:12 jamietanna

A quick fix until this is implemented; if you convert your PR to a draft and then click the "Ready for review" button, it will re-trigger the notification in Slack.

Screen Shot 2022-04-06 at 12 10 27 PM

Screen Shot 2022-04-06 at 12 10 53 PM

bretthayes avatar Apr 06 '22 16:04 bretthayes

Checking since this issue is still old - is this still the right issue to track for the feature to get PR re-request notifications? Or is there somewhere else I should look to see the most recent info?

rdhelms avatar Mar 05 '24 19:03 rdhelms