slack icon indicating copy to clipboard operation
slack copied to clipboard

GitHub Enterprise support

Open bkeepers opened this issue 6 years ago • 39 comments

From the README:

This app officially supports GitHub.com and Slack.com but the team plans to support GitHub Enterprise and Slack Enterprise Grid in the future.

Our approach to GitHub enterprise support will be two-fold:

  1. Allow customers to run their own instance of the integration alongside their GitHub Enterprise installation

  2. Add support for GitHub Enterprise to the hosted integration

We have not current prioritized this work, but will consider it based on demand. Add a 👍 reaction to this issue to show your support.

bkeepers avatar May 03 '18 12:05 bkeepers

Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

stale[bot] avatar Jul 02 '18 13:07 stale[bot]

Thanks for making this bot. Just checking if there are any updates on this? I am debating either to wait for the update or use an alternative ( we host our own enterprise GitHub)

madsid avatar Jul 11 '18 21:07 madsid

@madsid, we're not actively working on this, but I reopening the issue since this is a feature that many others would like.

bkeepers avatar Jul 17 '18 18:07 bkeepers

This would definitely be very useful for those of us that run internal GHE but use Slack.com

jeffj254 avatar Jul 18 '18 20:07 jeffj254

Add me to the waiting list or let us know, how this can be done otherwise. We are happy users of Slack and GitHub Enterprise, so it absolutely makes sense to allow users to choose their origin service, instead of static github.com. Afaik previous GitHub integration on Slack allowed to connect GHEE repos to it (iirc it was just a webhook between repo and Slack), so for many of us this is a must have feature. Thanks a lot in advance!

davesade avatar Sep 27 '18 13:09 davesade

Bump!!

seangates avatar Sep 28 '18 16:09 seangates

Would love for this feature to get attention. Posting github links in Slack doesn't format them at all until this is finished. I started building a Slack app that hits the Github API and I format the PRs myself at the moment.

ponchieponcho avatar Oct 31 '18 13:10 ponchieponcho

Is there any progress on this integration? There are quite a few of us patiently waiting to empower our teams. Especially since some of us have thousands of developers who would benefit from it's capabilities.

seangates avatar Nov 21 '18 17:11 seangates

Since we built the integration as a workspace app and Slack is moving those features to bot tokens, it means the app won't work for Enterprise customers in its current form (you wouldn't be able to create the necessary Slack App). There's some refactoring needed to make this work with bot tokens, but then it should be much easier to setup. We don't have a timeline for completing this, but also if anyone wants to dive into the code and help out with that effort, feel free.

tcbyrd avatar Nov 21 '18 17:11 tcbyrd

Hello:

Please add me to the list of persons interested in having this functionality. We use GitHub Enterprise and Slack. We would like to be able to start moving the notifications we generate out of email and into Slack where they will be managed more effectively.

We have seen that there is a Slack (Legacy Notification) app that is available and works with GHE. Our concern with that is that it requires that Slack authenticates into our GHE instance to see our repos. From a security perspective, it's a much easier conversation for us to initiate if GHE is managing what repositories are connected to Slack and under what events they send messages. We're anticipating that a GHE app would simply push messages to Slack.

We'll eagerly look forward to seeing some development on this.

Thanks.

Kevin

kconway-tangerine avatar Dec 18 '18 20:12 kconway-tangerine

Please add me to the list of interested in having this also. I am not sure why slack APP "GitHub Notifications (Legacy)" will be retired as it is only GH webhook instead of GH service, we strongly suggest don't retire this Slack APP until alternative GH APP be born. Thanks!

yiwu1 avatar Jan 02 '19 07:01 yiwu1

Did anyone started working on this? Could we start it? It is really important to have support to GHE as the number of users of that deployment model just grow very quickly...

galvesribeiro avatar Apr 21 '19 20:04 galvesribeiro

I posted in this thread back in October '18. This is still an issue for us and would like to hear from a dev if this will be implemented in the future.

ponchieponcho avatar May 09 '19 20:05 ponchieponcho

I was contacted by the GHE representatives that pointed me to the old version of the extension. That is the only supported by GHE for now.

They are working on make the new version of the extension to work on GHE but no ETA yet, so unfortunatelly we have to stick with the old one for now...

galvesribeiro avatar May 09 '19 20:05 galvesribeiro

Where can I find the old version of the extension?

muhammad-dewji-hs avatar May 09 '19 21:05 muhammad-dewji-hs

On your slack apps, search for GitHub Notifications (Legacy)

That is the old one... It doesn't have the nice features from the new one but at least we have notifications...

galvesribeiro avatar May 09 '19 21:05 galvesribeiro

My channel can receive the notification for commit, pull request..etc But failed to receive "Release" Did anyone receive the notification for "Release"?

silencev avatar May 14 '19 02:05 silencev

Does the legacy codebase for Github Notifications(legacy) still exist for us to deep dive into and add support where we can?

I wanted to take a look and see if I can connect CODEOWNERS with the message notification system so certain users get pinged on Slack based on certain directory/file changes.

klammm avatar May 29 '19 22:05 klammm

Any way I could help here, folks?

Dispader avatar Jul 01 '19 16:07 Dispader

Also very interested.

jcarlson avatar Dec 05 '19 18:12 jcarlson

Did it ever went somewhere?

galvesribeiro avatar Dec 05 '19 18:12 galvesribeiro

🙏

michael-basil avatar Feb 21 '20 04:02 michael-basil

Please do this.

Efpophis avatar Mar 06 '20 21:03 Efpophis

This is currently the 2nd highest requested feature, and is two years old. I see that no commits have been made to this repo in 2020 so far, so it doesn't seem to be getting much attention.

Has anyone investigated what would be necessary to enable GitHub Enterprise support?

rturknett avatar Apr 27 '20 15:04 rturknett

@rturknett I did a short discovery over the code some months ago - it should not be a big problem to make this ready for GHE.

From what I understood only the URL has to be changed here:

https://github.com/integrations/slack/blob/master/lib/github-url.js#L6

And OAuth2 config here:

https://github.com/integrations/slack/blob/dfd7e15e0db44ad05edd59309b22436243b53102/lib/frontend.js#L66

And:

https://github.com/integrations/slack/blob/09969eb928c6e323e15311129698c75e5c6c2c66/lib/github/oauth.js#L55

I had no time to test this out, yet - but maybe some other one did and can share some insights?

defel avatar Apr 27 '20 17:04 defel

Please think about adding support in GHE. Most enterprises host their own GHE so it should be a natural next step to proceed with the integration with highest priority.

sunnypatel2141 avatar May 01 '20 19:05 sunnypatel2141

🙏 This will make the lives of so many people so much easier that I can't explain it with words. I believe it is more important today more than ever.

bar avatar Jul 01 '20 23:07 bar

Hi there, adding a vote for this as well; it would go a long way for us since we use Slack.com, but host our own GHE.

chris-del avatar Jul 06 '20 21:07 chris-del

I opened a PR to allow for a self-hosted option that supports GHE https://github.com/integrations/slack/pull/1055

barlock avatar Aug 03 '20 14:08 barlock

My organization recently upgraded to Enterprise SaaS and we lost functionality with this integration. Normally I would expect to see more options with an upgrade so this is very dissapointing.

Please don't let this languish unsolved much longer.

heathsnow avatar Mar 24 '21 17:03 heathsnow