slack icon indicating copy to clipboard operation
slack copied to clipboard

Unfurled previews are too big

Open davidcelis opened this issue 6 years ago • 43 comments

Sometimes a teammate will open a PR, and the preview ends up being so big that it's almost as big as the Slack window itself (which is maximized)!

toobig

I feel like these previews could be condensed much more; there's so much text before the Show more link ends up being displayed, and its exacerbated by the PR having an image that gets previewed below

davidcelis avatar May 02 '18 21:05 davidcelis

The Desktop team is having issues with previews taking up too much real-estate causing our conversations to be lost in the mix. Something that would solve this problem for us is to not automatically expand a notification. Instead, allow the expansion of a notification to be an opt-in by the person viewing it. I've sent @bkeepers a DM with a GIF illustrating how much screen is taken up by these.

iAmWillShepherd avatar May 30 '18 00:05 iAmWillShepherd

Thanks for the feedback!

Instead, allow the expansion of a notification to be an opt-in by the person viewing it.

Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages.

We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count).

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.

Would that solve your problem here?

bkeepers avatar May 30 '18 14:05 bkeepers

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications. Would that solve your problem here?

Yes, I think that's a fine solution given the constraints Slack places on us.

iAmWillShepherd avatar May 30 '18 15:05 iAmWillShepherd

JIRA integration similarly offers a configuration that gives you a condensed version of previews.

jprestel-rue avatar Jun 07 '18 19:06 jprestel-rue

Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

stale[bot] avatar Aug 06 '18 20:08 stale[bot]

Yes still a desired feature.

jprestel-rue avatar Aug 06 '18 22:08 jprestel-rue

This is an important fix, it's basically stopping our org from adopting this integration because it basically spams the entire channel.

pmyjavec avatar Aug 14 '18 01:08 pmyjavec

This is still an issue in the #desktop channel as well.

iAmWillShepherd avatar Aug 14 '18 03:08 iAmWillShepherd

I would also like to be able to configure certain event types to always be condensed. For example, one pull request in my channel right now takes up 6 lines:

Pull request opened by <username>
<icon> <username>
#<issue number> <issue title>
Labels
<label>
<repo> | <timestamp>

That's way more than the old integration and also way too much detail for that. I'd much rather:

<icon> <username>
Pull request opened: #<issue number> <issue title>
<repo> | <timestamp>

ziggythehamster avatar Aug 27 '18 20:08 ziggythehamster

Also if I look at the screenshot OP posted, then he's having exactly the same issue I am, except that the PR I'm looking at doesn't have a description in it. I think there's a bug here, so I've opened a new issue: #668.

ziggythehamster avatar Aug 27 '18 20:08 ziggythehamster

I would also like to bump this feature as something that would be perfect to handle with a small user configuration option. The option be either be at the Channel level or overall App level (maybe Channel settings would override App).

As mentioned earlier, the Jira <-> slack integration allows you to choose between a Message Style of what they call Clean and Compact. Something similar here would be amazing, as currently Previews can be really large, especially if there is an image in the PR body.

mikelax avatar Oct 26 '18 13:10 mikelax

Experiencing the same problem with noise from verbose previews. A very good description of the issue can be found here: #595.

In my ideal world, a github PR/issue preview would only have a few of lines mentioning: repo, PR title, author, status (open/closed), and labels.

antonmorant avatar Nov 01 '18 23:11 antonmorant

Issues are too large, it's terribly distracting. We can't use the GitHub integration at all because of this.

NathanSweet avatar Dec 15 '18 21:12 NathanSweet

I ended up uninstalling this integration and going back to the "Legacy" Github Notifications app for my team. It's a pity because controlling subscriptions from slack with commands is a great idea, but the core functionality is just not going to work if you can't control messages' appearance.

antonmorant avatar Dec 18 '18 16:12 antonmorant

The unfurling is just too much information most of the time:

image

Seriously, this is too much. Please chop it down or reduce the image size or let us configure how much unfurls.

skyvondave avatar Feb 13 '19 17:02 skyvondave

Months go by and this continues to be terrible.

NathanSweet avatar Feb 13 '19 18:02 NathanSweet

@skyvondave That's not related to the GitHub integration… That's just a regular link unfurl. For the Google Play store.

davidcelis avatar Feb 13 '19 18:02 davidcelis

A condensed version of the output would be perfect. Just omit certain fields that get pushed to slack.

bluetidepro avatar Feb 25 '19 16:02 bluetidepro

These messages are way too long, especially for those of us who use checklists and PR templates.

rgeraldporter avatar Feb 26 '19 16:02 rgeraldporter

+1 -- This is still an issue for our team, would be great if there was more flexibility in how much is shown

liangmicha avatar Apr 19 '19 18:04 liangmicha

+1 to this. We enabled this recently and now everyone is hating it for too much information, if this is not fixed soon, we might just move away from this integration

mohammedzee1000 avatar Jun 26 '19 05:06 mohammedzee1000

Please fix faster. It's been a year. We loved the integration, but nearly instantly turned it off due to the spam.

repsejnworb avatar Jul 02 '19 08:07 repsejnworb

when multiple github PRs are linked it shows a lovely condensed version of the PR title and just chills. Why is the bot so extra when it's just one link?

jLouzado avatar Sep 19 '19 16:09 jLouzado

@skyvondave That's not related to the GitHub integration… That's just a regular link unfurl. For the Google Play store.

Slack is unfurling too much text and too large of a picture. It adds up to taking up a crazy amount of space and overwhelming the hand-typed message above it.

skyvondave avatar Sep 19 '19 19:09 skyvondave

Thanks for the feedback!

Instead, allow the expansion of a notification to be an opt-in by the person viewing it.

Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages.

We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count).

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.

Would that solve your problem here?

@bkeepers - I think the condensed view would be a great feature. Is this work captured anywhere? Should I open a new issue asking for this feature or is this issue sufficient?

jpbufe3 avatar Feb 14 '20 19:02 jpbufe3

@jpbufe3 It looks like #162 is the request you're looking for?

gareth avatar Apr 15 '20 12:04 gareth

@jpbufe3 It looks like #162 is the request you're looking for?

@gareth yes! Might be good to close this issue and mark it as a duplicate of #162?

jpbufe3 avatar Apr 15 '20 12:04 jpbufe3

👍 this is keeping me up at night thinking I've caused wasted pixels on my fellow team mates super wide screen monitors - I've lodged a support ticket too

export-mike avatar Mar 02 '22 03:03 export-mike

image

So, you are telling me that this is the intended behavior for the GitHub slack integration? Why do you (or Slack) breaks the line after ~ 100 characters when I have a widescreen QHD display? Every notification could fit in a line... This wastes the pixels on my monitor...

FlipEverything avatar Mar 26 '22 09:03 FlipEverything

It's pretty obvious by now that no one cares.

NathanSweet avatar Mar 26 '22 11:03 NathanSweet