slack
slack copied to clipboard
integrations
Allow subscribing to new/merged/closed PRs separately
Apologies first of all if this issue already exists. And also thanks for this integration, really enjoying it so far.
I think it would be quire nice if we could configure which pull request events we can subscribe to. Something like:
-
pulls:all- Opened, closed and merged PRs -
pulls:new- Opened PRs -
pulls:closed- Closed PRs -
pulls:merged- Merged PRs -
pulls- same aspulls:all, default (keeping current behaviour).
The use case for this is we have a channel where we like to post PRs that are ready for review, but is mainly used as a discussion channel which we don't want to be full of unneeded messages. We have another channel where we subscribe to all activity for reference.
I'm happy to give this a go, will look at opening a PR in the next few days unless someone is already working on something similar.
+1 to this. We want to use this tool to have a changelog of all merges into our major clusters that doesn't have all the noise from open/closed PRs. This would be a major improvement to the tool!
Subscribing here too. On current project I'm working with non-tech people who get confused and think the "pull request merged" is just another "Oh, new PR, click me". Would love to have a flag to get notification only when a PR is created.
+1 to this issue
Would be very nice in order to communicate what has been merged to stakeholders (like @filipetedim).
@richardnias can you provide more detail about the event-type you need for your use-cases?
Are opened, merged, closed and the default all, everything you need?
Everybody else is invited to share their requirements too.
@scepticulous I think opened, 'merged', closed and default all would be an ideal scenario for us. This would allow us to just have a channel with all closed PRs to surface while individuals would still be able create custom channels for all open PRs in repos they are interested in.
I think those 4 cover most use-cases. I don't know if updated could be an event also.
@scepticulous a special case that hasn't been mentioned yet is draft PRs. we currently get notifications both when a draft is opened and when it's marked as ready for review, but we'd prefer to filter those as needed
+1 on this. Our team just needs to know about new pull requests. Without it, we are getting double the notifications we need and are considering dropping this integration.
A related suggestion - it would be great if subsequent notifications of an opened PR could be sent to a thread on the original message.
- New PR opened: ...
<in the thread>
- Bob added a comment
- Bob pushed a commit
- Nancy added a label
- etc
I just want the status to be updated in the main post. Open, Approved, Rejected, merged, closed One post per PR. Though being able to limit other than new would be a ok workaround.
This may be out of scope, but while we're on the subject of this, it would be nice to have approvals show up within the initial PR notification, like of like CI checks are now.
There should also be an option to filter out draft PRs as I don't want my team to be notified about a PR until I'm ready for them to review it.
If anyone is looking for an interim solution, I've found that using Zapier provides a much less frustrating experience than this GitHub integration.
Trigger: [Github] New Pull Request
Action: Post to a Slack channel
It does still include draft PRs, but it doesn't post for merges or closes, which is much better for my team.
Would be great to have a merge-only option so that we can pull merge notifications into our community Slack to show velocity for the project without spamming too much.
this is a blocker for this entire integration for me, and has been for a year
