slack
slack copied to clipboard
integrations
Direct Message when a Review is Requested
Review Requests are a great way to get feedback and I use them daily but they quickly get lost/deleted in my email.
Currently, I use slackbot to remind me to check my "Reviews Requested" page but it would be awesome if I could opt-in to have the GitHub app send a Direct Message whenever a review was requested and then updated the message once I reviewed.
Maybe it could be enabled by sending a Direct Message to GitHub like the following: subscribe */* review-requests
The command I currently use is /remind me "Check https://github.com/pulls?q=is%3Aopen+review-requested%3Aphilschatz" every day
This should be configurable, e.g. users should be able to determine if they are notified in Slack for review requests, and how (message, message in a specific/special channel, or DM).
This would be awesome! Specifically, my team would like to have the following:
- Whenever someone is added to a PR, the GitHub Slack bot tags them in a message.
- If a PR hasn't been reviewed after a certain amount of time (usually because somebody forgot), then it sends them a reminder message.
Also, it'd be great to have the "Reviewers" section of an open PR just below the "Assignees" one:
Github explicitly has this event but I wonder why this has not been implemented. Even if the channel the bot posts to gets an update saying that review has been requested on certain PR it would be really helpful.
We were also interested in this functionality, but at the same time we started using Pull Reminders from the GitHub Marketplace.
Pull Reminders does DMs for review requests, which is cool but it was the periodic reminders for our team that we we really needed. Some guys on our team need consistent reminders instead of 1, and we wanted to control that, as well as having some of the reporting features.
In our team, we use "request a review" in a way that people self-request themselves to pull requests. We have a slack channel for noticing opening of new pull requests and the one who decides to do the review gives others heads up there in order to avoid too many people reviewing the same PR at the same time. We would love to have the slack integration be able to show on the channel whenever someone adds themselves as a reviewer to a PR as that would automatically inform everyone.
I implemented one on my own. And I've made its setup steps as simple as possible.
https://github.com/EnixCoda/GitHubReviewerNotificationForSlack
It makes my life much easier!
@sebbean Check out http://github.com/marketplace/pull-reminders.
You can subscribe to DM notifications for issue and pull request related events including:
- Review requests
- Team review requests
- Reviews
- Comment on your issues or PRs
- Comment mentions
- Team comment mentions
- Replies to comments you've posted
- Merge conflicts
- Failed CI checks
I maintain Pull Reminders so if pricing is problematic for anyone, please email me at [email protected] and I'd be happy to give your team a free account.
@abinoda i'm using it! it's great! thank you so much.
is there a way to get reminders/notifications for when a PR has been approved? seems like the last piece of the workflow puzzle.
@sebbean If you go under "My DM Settings" there should be an option for getting a DM when your PR is approved. We shouldn't clog up this issue with discussion so feel free to open an issue here.
GitHub has acquired Pull Panda, the makers of the Pull Reminders app discussed above: https://github.blog/2019-06-17-github-acquires-pull-panda/
We plan to integrate these features into GitHub but hope you’ll start benefiting from them right away
Should this be marked as closed now? I almost navigated away after Googling and ending up here because i assumed "Open" meant this wasn't yet possible. But then i found Pull Panda in the thread here
Thanks, everybody for your awesome input.
It is likely that we are going to add some functionality related to this to the official Slack integration independent of the pull reminders integration.
I have a quick question to everybody involved: Is this functionality required to be a "DM" or is anybody also looking for PR assignments in the regular channel subscription. This the core idea of this features seems "assigned to me" it seems as if DM is the core idea. Please let me know if there are other use-cases.
cc @philschatz @philschatz @ryandeussing for DM feedback
cc @LandonSchropp since your idea sounds more to be around "sending the assignment event to the channel and '@'-mention the user that is assigned directly or through a team membership".
Adding "reminders" is currently out of scope for the official Slack integration.
Since I posted that message, we've started using Pull Reminders, which does exactly what we needed. When someone is assigned a PR review, it sends them a DM directly letting them know.
Is this functionality required to be a "DM" or is anybody also looking for PR assignments in the regular channel subscription.
For my team either one is fine. We want to bring the fact that someone was requested as a reviewer to their attention on Slack - we're not too fussed about how it gets delivered, so whatever is easier to implement we'd be happy with @scepticulous
Is this functionality required to be a "DM" or is anybody also looking for PR assignments in the regular channel subscription.
I prefer the channel-orientated vector (allowing for round-robin, pick-up PRs within specific teams) but not too put off if that's not available out of the gates
It seems that Pull Reminders/Pull Panda have been removed from the market place, is there any update the having this feature in the official app, or any new alternatives?
Yeah. Do I now have to wait until this has been integrated with Github? Is there a timeline estimate?
ping @dennissivia @abinoda this feature is very high value for our workflows at work, can we please get an update on what's going on here? I see there's a PR implementing this feature here => https://github.com/integrations/slack/pull/861
@tebriel @wilhelmklopp @jules2689
this feature is very high value for our workflows at work, can we please get an update on what's going on here? I see there's a PR implementing this feature here => #861
Would love to see this feature. A great alternative to having to subscribe to a whole repo where hundreds of committers across multiple teams are contributing. The noise would be too much. This feature would solve that!
We ended up using Toast for our team: https://slack.com/apps/AC6M092SD-toast
Works great and supports direct messages to requested reviewers among other features.
The plan is to add this and many of the other Pull Panda DM features to GitHub in the next month or two. Once available, you'll be able to configure them via your GitHub settings page. Watch the GitHub blog for updates.
Thanks so much for the info @willsmythe! It would have been nice to have gotten an update on this earlier, but I super appreciate you letting us know now 🙏
https://github.blog/changelog/2019-11-14-scheduled-reminders-beta you can sign up the beta is open!
https://github.blog/changelog/2019-11-14-scheduled-reminders-beta you can sign up the beta is open!
This looks to be missing two basic features (yes, I know it's a preview):
- per repo/per channel settings (rather than per user/team), so I can say "for repo x and y if a PR review is requested DM the appropriate user" rather than every single person having to do that for themselves
- timezone aware daily reminders - my team is globally distributed and not being able to remind users at, say 9am their time is a drawback